On Tue, 2016-05-17 at 16:55 +0100, Ghislain Vaillant wrote: > On 17/05/16 15:42, lumin wrote: > > Thank you for this careful and thorough review!
http://anonscm.debian.org/cgit/debian-science/packages/caffe.git/ Let me summarize the changes this time * remove python script for autogen, generate install control file in rules instead. The trick used is borrowed from CUDA packaging. * update content in install control file, including removing debian/tmp. * add caffe-doc package * change target release from experimental to unstable * add 3 new patch: - cmake-using-basic-blas - cmake-using-gnuinstalldirs - cmake-fix-python-module-installdir * removed unapplied patches. * update README.Debian * remove custom target in rules, since standard build is not heavy anymore. * fix many lintian Warnings for caffe-doc in rules * add debian/tests/control, and a simple test debian/tests/simple * use uversionmangle in watch, version parse ok * add debian/upstream/metadata , but lintian says > W: caffe source: upstream-metadata-yaml-invalid Is there anything wrong with this file? I have no idea ``` Homepage: http://caffe.berkeleyvision.org/ Name: Caffe Reference: Author: Jia, Yangqing and Shelhamer, Evan and Donahue, Jeff and Karayev, Sergey and Long, Jonathan and Girshick, Ross and Guadarrama, Sergio and Darrell, Trevor Title: Caffe: Convolutional Architecture for Fast Feature Embedding Journal: arXiv preprint arXiv:1408.5093 Year: 2014 URL: http://arxiv.org/abs/1408.5093 eprint: http://arxiv.org/pdf/1408.5093.pdf Repository-Browse: https://github.com/BVLC/caffe ``` well, the above issue seems to be the last one before it can be uploaded. when I'm writing this email debomatic is still compiling: http://debomatic-amd64.debian.net/distribution#unstable/caffe/1.0.0~rc3-1/buildlog