Dear G, Thank you for reviewing my package!
Changes are push to branch pkg3 of github: https://github.com/rogers0/shadowsocks-libev And package on mentors also get updated. (Only fixed the description issue, though) On Wed, Jun 1, 2016 at 5:52 AM, Gianfranco Costamagna <locutusofb...@debian.org> wrote: > 1) I: shadowsocks-libev: extended-description-is-probably-too-short Fixed now. > 2)W: shadowsocks-libev source: debian-watch-file-should-mangle-version line 7 It's false positive. Same answer for libcork in RFS. I don't do workaround because I want to see when it will be resolved. :-) > 3) > Replaces: shadowsocks (<< 1.5.3-2) > Breaks: shadowsocks (<< 1.5.3-2) Thanks to co-maintainer Boyuan, below comments are from him. ==== Upstream used to use the package name **`shadowsocks'** long long ago, and the name was changed into `shadowsocks-libev' [0] since version 1.5.3-2 in order to prevent the naming conflict with python version of shadowsocks [1]. Upstream has been providing debian directory for a really long time (earlier than v1.3), so someone may be installing the *libev* version of debian package called `shadowsocks'. You may notice that for python version of shadowsocks, the **initial** release was 2.1.0 [2] and will not bother with shadowsocks << 1.5.3-2. . So setting Replaces / Breaks: shadowsocks << 1.5.3-2 should be the best way to deal with those two problems. [0] https://github.com/shadowsocks/shadowsocks-libev/blob/master/Changes#L205 [1] https://packages.debian.org/sid/shadowsocks [2] http://metadata.ftp-master.debian.org/changelogs//main/s/shadowsocks/shadowsocks_2.1.0-1_changelog ==== > 4)libipset/ <-- debian has libipset-dev, please make sure that one is used > during build > (if it is the correct lib of course) Debian's libipset-dev has nothing to do with files in libipset/ folder. I did tried to package this, failed. As I explained in other email to you as paste below: ==== I didn't package ipset because: - Almost dead upstream. There're a few questions and pull request is pending on github for years. - I cannot compile by the steps described in upstream's INSTALL file. It failed on linking. - Current embedded library just works, because shadowsocks-libev's upstream has modified this library to improve compatibility on multi-platform. ==== > 5) > sed -i "/dependency_libs/ s/'.*'/''/" `find . -name '*.la'` It's workaround for lintian: https://lintian.debian.org/tags/non-empty-dependency_libs-in-la-file.html > 6) debian/config.json It's runtime config file, which will be installed to: etc/shadowsocks-libev Hope you feel the updated package more comfortable. Thanks again! Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 17B3ACB1