Control: tags -1 moreinfo Hallo Pali,
(I won't sponsor this because I will not find time to do so before the Stretch-Window will close, except you'll be very fast in providing an updated package) Here's a review: - d/changelog: The changelog for 1.5-1 has a different timestamp than the one in the archives. Please make sure that you base your changes *exactly* on the state that have been uploaded. - d/compat could be bumped to 10 - is Vcs-Bzr: lp:smpq really working? (not sure, my bzr seems broken atm) This also causes linitian to bark: I: smpq source: vcs-field-uses-insecure-uri vcs-bzr lp:smpq - The version of the B-D on libstorm-dev is not needed -- there is no older version in Debian - The README file does barely contain information beside building instructions and therefore should not be installed. - please do not shout in d/changelog (CHANGELOG; dh_installchangelogs will rename CHANGELOG to changelog.gz anyway, so it is not needed to write in uppercase. BTW, the override in d/rules is not necessary. dh_installchangelog will find it even when written uppercase. - check if you can add the "as needed" linking flags to fix: dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/kio-smpq/usr/lib/kde4/kio_smpq.so was not linked against libgcc_s.so.1 (it uses none of the library's symbols) Please fix those and remove the "moreinfo" tag afterwards to indicate that you're ready for the next review. -- tobi