On Thu, Feb 9, 2017 at 4:47 AM, Gard Spreemann <gspreem...@gmail.com> wrote: > On Wednesday, 8 February 2017 18:46:46 CET Roger Shimizu wrote: >> Dear Gard, >> >> I cannot sponsor the upload. But here's my review that I hope it's helpful. > > Dear Roger, > > Thank you very much for your helpful feedback. I believe I have > rectified some of the below. > >> Here're the items need to be fixed: >> - missing in debian/copyright, not GPL-3+ license: >> cmake/modules/FindEigen3.cmake >> cmake/modules/FindTBB.cmake >> include/gudhi/Contraction/CGAL_queue/*.h >> data/points/COIL_database/images/* >> doc/*/*.png >> Better to ask upstream to confirm license of those image files. >> Usually license of image files is different from the code. If it's not >> sure simply remove it from "debian source" repack. > > Good catch! I'm sorry for overlooking this. I'll get to work > clarifying the licenses and/or stripping out these.
I mean there're src files under other than GPL-3+, which is totally fine. But you need to sort them out, list all the licenses and their src files. Please take a look at my package as example: - https://anonscm.debian.org/git/collab-maint/shadowsocks-libev.git/tree/debian/copyright >> - lintian reports: >> I: libgudhi-dev: spelling-error-in-copyright unneccessary unnecessary > > Fixed. > >> Other comments, nice to have: >> - it's more convenient if you can export your work to some modern >> SCM, such as git >> the review will be easier if doing with such SCM >> you can omit the final releasing commit, so if there's something >> still need to work, you don't have to push forcefully. > > Done; https://git.nonempty.org/debian-gudhi/ > >> - add Vcs-* line to d/control (depends on the above item) > > Done. > >> - bump to debhelper 10 > > Done. > >> - wrap and sort Build-Depends & Depends list in d/control > > Done. Great! On Tue, Feb 14, 2017 at 7:13 PM, Gard Spreemann <gspreem...@gmail.com> wrote: > On Wednesday, 8 February 2017 20:47:07 CET Gard Spreemann wrote: >> On Wednesday, 8 February 2017 18:46:46 CET Roger Shimizu wrote: >> > >> > - have separated -doc package >> >> The documentation shipped with upstream's source is rather >> limited. They instead ship a dedicated tarball for documentation >> [1]. I intend to package it too, and have it provide the -doc >> package. >> >> Does this sound sensible to you? > > Scratch that. My package now generates the doxygen documentation and > builds a -doc package. Great! >> I'll upload a new version to mentors.debian.net when I hear back >> from upstream regarding the missing copyrights. > > Upstream say they will take into account my remarks regarding > licensing for the next release. I'll upload a new version to mentors > when that happens. I guess only image files need to confirm, right? We can wait for the version you're satisfied with. > The version on https://git.nonempty.org/debian-gudhi/ has diverged a > bit from the mentors one meanwhile. Most importantly, it now builds a > -doc and an -examples package. Any comments would be greatly > appreciated. No problem about the divergence, git repo is just easy to track what you've changed. Look forward to your updated upload next time. Thanks for your effort! Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1