Juhani Numminen schrieb am 2017-09-10 um 17:27:
Ross Gammon kirjoitti 10.09.2017 klo 13:15:
I would be happy to take a look at this. Unfortunately, I am quite busy
at the moment so I can't promise much this week.
I have cc'd you because you did not say whether you are subscribed to
the Multimedia list. I have also copied in the RFS bug so that other
potential sponsors see this and take over if they are looking for
something to do :-)
Regards,
Ross
I can review the package and offer my comments in the meantime.
Disclaimer: I am not Debian Developer or Debian Maintainer.
Thank you Ross and Juhani!
Your package is not lintian-clean, please investigate (lintian -EviI
--pedantic) and fix what you can.
W: parlatype source: newer-standards-version 4.0.1 (current is 4.0.0)
I guess no need to override this.
I: parlatype source: testsuite-autopkgtest-missing
There are no tests and it's only informational, should I override this?
P: parlatype source: debian-watch-may-check-gpg-signature
fixed
debian/control:
I think Section: sound would be more suitable than Section: gnome.
done
You can drop some version requirements, please run 'cme check dpkg'.
done, intltool didn't need versioning
Latest Policy version is 4.1.0.
done, changed watch file (checking for signature)
Didn't test or change for "4.15: Packages should build reproducibly"
Do you expect me to test reproducibility?
Please use https for the homepage address.
done
The Debian changelog for new packages is usually very simple. This
should be enough:
parlatype (1.5.2-1) unstable; urgency=medium
* Initial release (Closes: #868886)
-- Gabor Karsay <email> Thu, 10 Aug 2017 17:43:18 +0200
done, removed old changelog entries. They were either never released,
just for private purposes, or Ubuntu PPA releases.
debian/copyright should use the established short license names, i.e.
GPL-3+ for "version 3 or later" and CC-BY-SA-4, not CCBYSA-4. They are
listed in the format specification.
done
For the CC licenses, I think it is not enough to just refer to a web
page, as the terms must be readable offline.
done, included full CC licenses
See if any http URL can be changed to https in this file, too.
done
In debian/rules, based on my testing, I can tell these two lines are not
needed:
DPKG_EXPORT_BUILDFLAGS = 1
include /usr/share/dpkg/buildflags.mk
done, removed
I have still a question: There's a build-dependency for
libfile-fcntllock-perl only to avoid a warning in the build log
"dpkg-gencontrol: warning: File::FcntlLock not available; using flock
which is not NFS-safe". But it builds also without, can it stay for a
cleaner build log or should I remove it?
Thank you
Gabor
