Control: owner -1 ! Control: tags -1 moreinfo On Mon, Mar 12, 2018 at 10:58:19AM +0100, Mateusz Łukasik wrote: >... > Changes since the last upload: > * New upstream release. (Closes: #892054) > + Drop all patches included upstream. > * debian/control: > + Bump debhelper version to 11. > + Bump to Standards-Version to 4.1.3. > + Add e2fsprogs to depends. (Closes: #887177 #887257) > * debian/patches: > + Add drop-gnome-common-macros.patch to drop deprecated gnome-common > macros/variables. (Closes: #830003) > * Update debian/copyright. > * Drop changes from Ubuntu - fixed upstream. > * Drop postinst script and clean postrm. (Closes: #860846)
Looks good, except for two problems with a790d3f0f665601a873a50e350bbf684bdf1ac04.patch: 1. The patch is not mentioned in the changelog. 2. A git commit id is not a good patch name. This makes it impossible to see what is in a patch. "git format-patch -1 <commit>" is a good option for getting a properly named patch. > Regards, > Mateusz Łukasik cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed