On Fri, Oct 26, 2018 at 01:43:52AM +0000, Dmitry Bogatov wrote: > I like idea of this package, so below is my review; mind you I do not > host any Postfix servers, so I did not checked that it actually works. > > * Standards-Version: 4.2.1
Changed. > * cp zeyple/zeyple.py zeyple/zeyple fails on second invocation of > dpkg-buildpackage. Either (in decreasing order of preference) > > + use dh-exec, which allow you to install and rename Changed. > * Build-depend on debhelper >= 11~ (mind the tilde). Be nice to > backporters. Changed. > * Seems that source is written to be compatible with both python3 and > python2. If it true, use python3 dependencies. Changed. > * In postinst you create user, but never removes it. Please fix it. > Consider using dh-sysuser, which tries to automate bookkeeping of > system users. Changed. > * You seems to run upstream tests as autopkgtest. Any chance to run it > at build time? Changed. > * There seems to be typos in zeyple.1 I can't seem to find any typos, could you give an example? > * Maybe it is just my ignorance, but I do not understand reason for the > patch. Mind to write dep-3 description? Added. These changes are on Salsa: https://salsa.debian.org/zebmccorkle-guest/zeyple -- Piper McCorkle (transitioning s/Zeb(ulon)?/Piper/) zebmccor...@asymptote.club | https://keybase.io/zebMcCorkle 803A 0F47 82AD DDEA 46BE 055F F8F9 DB8C 1A54 6398 | | __/ __ Asymptote Club / (bad ASCII graph by yours truly) | |
signature.asc
Description: PGP signature
