On Mon, Apr 01, 2019 at 12:57:51AM +0200, Andre Noll wrote: > On Sat, Mar 30, 23:58, Adam Borowski wrote > > On Thu, Mar 28, 2019 at 11:41:45AM +0100, Andre Noll wrote: > > > * Package name : lopsub > > > Version : 1.0.2
> > This library is certainly not something for Debian only, thus please append > > "-1" to the version, and set debian/source/format to "3.0 (quilt)" (which, > > despite the name, doesn't require actually using quilt). > > Sure, I just wasn't aware of this convention, and that "3.0 (quilt)" > is the right choice for a package like lopsub. One question: With this > change applied, dpkg-buildpackage wants the upstream tarball in the > parent directory. I guess I'm supposed to run git archive here to > create it as part of the before-build hook, but I couldn't figure > out where this hook is defined. There are many workflows for this, but my personal favourite is to skip any such wrappers and rely on uscan (ie, debian/watch) only. As most project will want a watch file anyway, this reduces the amount of work. Alas, the vast majority of projects use a git host that does provide tarballs for a tag, thus I have never used uscan with mode=git (as downloading a tarball is still more likely to produce a reproducible result), and thus can't give you ready copypasta to use. > > I see a static library installed by the package. Those shouldn't generally > > be used unless you're doing something special -- static linking makes > > security and bugfix updates extremely tedious. Libraries should also be > > split into separate binary packages, with lib${name}dev providing > > development files while lib${name}${so} the runtime lib. > > Yes, I had this concern as well. I'll change the build system to > create a shared library instead and split the binary package as you > suggest. I'll follow up with another reply when it's ready. Sounds good. Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Did ya know that typing "test -j8" instead of "ctest -j8" ⢿⡄⠘⠷⠚⠋⠀ will make your testsuite pass much faster, and fix bugs? ⠈⠳⣄⠀⠀⠀⠀