Hi Adam, Thanks for the help! Very appreciated.
On Thu, Feb 13, 2020 at 9:17 PM Adam Borowski <kilob...@angband.pl> wrote: > On Thu, Feb 13, 2020 at 09:01:38AM +0000, Hsieh-Tseng Shen wrote: > > * Package name : ledmon > > Version : 0.94-1 > > > Changes since the last upload: > > > > * New upstream release 0.94. > > - Support for AMD IPMI enclosure management. > > - Support for NPEM. > > * debian/control: add pkg-config and libpci-dev as build dependency. > > * debian/control: update Standards-Version to 4.5.0. > > * Remove obsolete patch. > > Hi! > Besides things mentioned above, you also add installation of systemd > .service file. And, I see some problems there. > > + dh $@ --wth systemd > would look a bit nicer when spelt "--with". I didn't think I made ridiculous mistake here... oops > It would also make this section done automatically: > +override_dh_auto_install: > + dh_auto_install > + mkdir -p debian/ledmon/lib/systemd/system > + install -c -m 644 systemd/ledmon.service > debian/ledmon/lib/systemd/system > + dh_systemd_enable || true > + dh_systemd_start || true > > > Another problem is that you enable the daemon only for systemd. For any > other init/rc combination there's a need for an init script (and, it would > be enough for systemd too). Here's one: > > .--==[ debian/ledmon.init ] > #!/usr/bin/env /lib/init/init-d-script > ### BEGIN INIT INFO > # Provides: ledmon > # Required-Start: $syslog $time > # Required-Stop: $syslog $time > # Default-Start: 2 3 4 5 > # Default-Stop: 0 1 6 > # Short-Description: enclosure LED monitor > # Description: monitoring of storage enclosure LEDs > ### END INIT INFO > DAEMON=/usr/sbin/ledmon > `---- > I will refer some examples (e.g. network-manager) to finish init script, thanks. I don't why this bug needs to close, but anyway I will file a new bug after I fix all issues you mentioned. Woodrow > > > Meow! > -- > ⢀⣴⠾⠻⢶⣦⠀ > ⣾⠁⢠⠒⠀⣿⡁ > ⢿⡄⠘⠷⠚⠋⠀ A white dwarf seeks a red giant for a binary relationship. > ⠈⠳⣄⠀⠀⠀⠀ >
