Thanks Tobi for pointing out the transition. I did not know that. :( On Thu, Apr 16, 2020 at 4:35 PM Tobias Frost <t...@debian.org> wrote: > > Control: tags -1 moreinfo > > Hi Sudip, > > here's a review, no specific order: > > - it seems that there is an ABI bump in the libraries (as packages get > renamed and so on…). > Please target "experimental" for this upload, as this will trigger an > transistion [1] and also > needs to clear "NEW".
done > > - d/copyright needs some years updated. Bonus points for converting it to > dep5 (its almost already dep5, so likely quickly converted) I only noticed one change of year, which has been updated now. And, I could not convert it to dep5 as I could not decide on the license of debian/* that the previous people wanted to use. I will ping Johny (upstream) about it and check if he knows something and then have it updated in the next release. > > [1] https://wiki.debian.org/Teams/ReleaseTeam/Transitions > > - you should probably close #878198; I see the change but it is not mentioned > in the changelog. done. > > - you should probably also close #954252 (at least the bts says it is fixed > by the new upstream version) closed separately as it was already fixed by #946853. > > Regarding the symbols: Be aware that symbols are tricky for C++ code, > especially for different architectures… Lets see and wait how it turns out, > but > do not hesitate to undo that if you feel it becomes a burden. upstream was also not too much enthusiastic about having symbols and was telling me about problems that it might cause. dropped for now. :) Changes since the last upload: * Team upload. * Update to upstream v6.5.8 - Remove old patches applied upstream. - Use debian/* from upstream. * Update Standards-Version to 4.5.0 * Use debhelper-compat. - Update compat level to 12. * Update debian/rules. - Remove --list-missing. - Add -g for debug symbols. - Stop modifying flags directly. - Install shared library in multiarch location. - Remove LD_LIBRARY_PATH. * Update doc-base location. * Remove lintian overrides. - for symbols. - for debhelper. * Update maintainer to valid team email. (Closes: #899440) * Update Vcs link to salsa. * Update copyright year. * Drop transitional package gperf-ace. (Closes: #878198) -- Regards Sudip