Hi kokoye,

在 2020-06-17星期三的 21:42 +0630,Ko Ko Ye`写道:
> Dear Mentors 
> Now update 0.1-2
> https://mentors.debian.net/debian/pool/main/w/wifi-qr/wifi-qr_0.1-2.dsc
> 
> implement with Hidden Network.
> remove wifi-qr.policy
> remove sudo usermode
> change array to mapfile mode.
> and
> shellcheck with @pabs suggestion.
> https://github.com/kokoye2007/wifi-qr/issues/9

There are several issues:

* Since this is a new upload, please do not reuse your old RFS bug (
https://bugs.debian.org/961899). Please open another RFS bug with
correct version string (0.1-2) and we can discuss further there. Please
do not further reply to this bug report.

* You are actually making changes as an upstream to fix some issues. In
this case, please consider making another upstream release (for
example, 0.2). Putting your changes in debian/patches/ is not
reasonable at all. In this case you are the upstream, you have full
control of the original project and you should not bother with
patching.

* Please, delete the .pc directory (
https://github.com/kokoye2007/wifi-qr/tree/master/.pc) for good and
never let it appear in your git repo again. This directory should
*never* appear anytime anywhere and I have provided the reason to you
in previous emails.

* Finally, could you please write in full English sentences with
correct grammar in your email communication as well as the package
description (
https://github.com/kokoye2007/wifi-qr/blob/master/debian/control)
instead of using scattered words? That will definitely help with the
understanding.

Please fix the issues above and we can do further review in your new
RFS request thread.

-- 
Thanks,
Boyuan Yang

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to