Control: tags -1 moreinfo Hi Seunghun,
thanks for packaging swtpm, here's a review: (Note it is incomplete, I ran out of time. I do not intent to sponsor the package.) - Upstream has released 0.4.0 now, can you rebase your package this version please? - As it is a new package, d/changelog should only have one entry: "* Initial release. (Closes: #yourITP)" The rest has to go. - d/clean: I guesss "debian/autoreconf.*" shouldn't be needed. - d/control: - Are all those B-Ds required? (I thought debhelper will pull in automake/autoconf automatically, for example.) - Shared libary packages needs to names lib<libraryname><soname>. Are those *.so plugins or intended for other applicactions? Why are the installed into a swtpm subdir? - Same for dev pacakge: libswtpm-dev it is. - W: swtpm source: depends-on-misc-pre-depends swtpm-libs - P: swtpm source: package-uses-old-debhelper-compat-version 12 - d/rules: - override_dh_auto_test: How's about (untested) just writing: override_dh_auto_test: SWTPM_TEST_SECCOMP_OPT="--seccomp action=none" dh_auto_test (in any case, hardcoding -j4 is wrong; I also thought that the filter is not needed with recent debhelper.) - override_dh_auto_configure: dh_auto_configure will automatically call autoreconf / configure . No need to call autogen.sh. - *.install - manpages should be installed with dh_installmanpages(1) - You should add autopackagetests, as the source has a test suite. There are a lots of messages lintian, please look at them and try to eliminate them. Please remove the moreinfo tag once the above issues are checked/addressed. Thanks! Cheers, -- tobi
signature.asc
Description: PGP signature