On Fri, Aug 13, 2021 at 02:21:21PM +0200, Fabrice Creuzot wrote: > Okay, so I tried to build all binary packages from one source package. > Not sure if it's the good way. > > It builds those binary packages: > awf-gtk2 - A widget factory is a theme preview application for GTK > awf-gtk3 - A widget factory is a theme preview application for GTK > awf-gtk4 - A widget factory is a theme preview application for GTK
Generally, looks good to me. However, gtk-4 is available only in experimental. This will almost certainly change before your package leaves NEW (gtk4 maintainers are probably salivating at the thought of uploading to unstable ASAP, while NEW is very crowded), but let's have installable+buildable packages. There's no reason for a first upload of a package to go into unstable, too -- it needs a rebuild in any case. Nitpick: the short desc shouldn't be capitalized. Having no explicit debian/source/format is deprecated -- please declare the format. Also, while gtk2 and 3 binaries work for me, gtk4 crashes at start: Thread 1 "awf-gtk4" received signal SIGSEGV, Segmentation fault. create_treview (root=0x5555556a5780) at awf.c:1973 1973 if (strcmp (config, "0") == 0) (gdb) bt full #0 create_treview (root=0x5555556a5780) at awf.c:1973 scrolled_window = 0x5555559704c0 store = 0x555555909960 iter = {stamp = -1097518473, user_data = 0x5555558cc150, user_data2 = 0x5555556b7160, user_data3 = 0x0} config = 0x0 view = 0x55555593c3c0 renderer = <optimized out> hbox_columns = <optimized out> vbox_column1 = <optimized out> vbox_combo_entry = <optimized out> hbox_spin = <optimized out> hbox_check_radio = <optimized out> vbox_check = <optimized out> vbox_radio = <optimized out> vbox_column2 = <optimized out> vbox_buttons = <optimized out> hbox_btns1 = <optimized out> hbox_btns2 = <optimized out> hbox_btns3 = <optimized out> hbox_btns4 = <optimized out> vbox_column3 = <optimized out> vbox_progressbar1 = <optimized out> vbox_progressbar2 = <optimized out> hbox_progressbar1 = <optimized out> hbox_progressbar2 = <optimized out> vbox_column4 = <optimized out> vbox_others = <optimized out> hbox_label = 0x5555556a5900 hbox_spinner = 0x5555556a5a80 vpane = 0x5555555cb3b0 hpane1 = 0x5555555cb590 hpane2 = 0x5555555cb770 hbox_frame1 = 0x5555556a5c00 hbox_frame2 = 0x5555556a5d80 hbox_notebook1 = 0x5555556a5f00 hbox_notebook2 = 0x5555556d21f0 #1 create_widgets (root=0x5555556b7760) at awf.c:818 hbox_columns = <optimized out> vbox_column1 = <optimized out> vbox_combo_entry = <optimized out> hbox_spin = <optimized out> hbox_check_radio = <optimized out> vbox_check = <optimized out> vbox_radio = <optimized out> vbox_column2 = <optimized out> vbox_buttons = <optimized out> hbox_btns1 = <optimized out> hbox_btns2 = <optimized out> hbox_btns3 = <optimized out> hbox_btns4 = <optimized out> vbox_column3 = <optimized out> vbox_progressbar1 = <optimized out> vbox_progressbar2 = <optimized out> hbox_progressbar1 = <optimized out> hbox_progressbar2 = <optimized out> vbox_column4 = <optimized out> vbox_others = <optimized out> hbox_label = 0x5555556a5900 hbox_spinner = 0x5555556a5a80 vpane = 0x5555555cb3b0 hpane1 = 0x5555555cb590 hpane2 = 0x5555555cb770 hbox_frame1 = 0x5555556a5c00 hbox_frame2 = 0x5555556a5d80 hbox_notebook1 = 0x5555556a5f00 hbox_notebook2 = 0x5555556d21f0 #2 0x0000555555562e1c in create_window (app=<optimized out>, theme=<optimized out>) at awf.c:734 vbox_window = 0x5555556b7160 toolbar = 0x5555556b72e0 widgets = 0x5555556b7760 gmm = <optimized out> event = <optimized out> #3 0x00007ffff74450a2 in g_closure_invoke () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #4 0x00007ffff7457413 in () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #5 0x00007ffff745d6cf in g_signal_emit_valist () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #6 0x00007ffff745dc3f in g_signal_emit () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #7 0x00007ffff756a338 in () at /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0 #8 0x00007ffff756a4ae in g_application_run () at /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0 #9 0x00007ffff7161d0a in __libc_start_main (main= 0x55555555b060 <main>, argc=1, argv=0x7fffffffe008, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffdff8) at ../csu/libc-start.c:308 result = <optimized out> unwind_buf = {cancel_jmp_buf = {{jmp_buf = {0, 3035993641122779325, 93824992261632, 0, 0, 0, 9184899517099004093, 9184881029332193469}, mask_was_saved = 0}}, priv = {pad = {0x0, 0x0, 0x1, 0x7fffffffe008}, data = {prev = 0x0, cleanup = 0x0, canceltype = 1}}} not_first_call = <optimized out> #10 0x000055555555b62a in _start () Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ If you ponder doing what Jesus did, remember than flipping tables ⢿⡄⠘⠷⠚⠋⠀ and chasing people with a whip is a prime choice. ⠈⠳⣄⠀⠀⠀⠀