Re: r-cran-ncdf4: ftbfs with autoconf 2.70

[Jeremy Sowden]

On 2021-09-08, at 16:06:34 +0200, Andreas Tille wrote:
> Control: tags -1 help
>
> Hi,
>
> I need to admit that from my naive perspective this is a bug in
> autoconf.  In the log that is provided in the bug report[1] you can see
> this here:
>
>    dh_autoreconf -O--buildsystem=R
> configure.ac:44: warning: AC_OUTPUT should be used without arguments.
> configure.ac:44: You should run autoupdate.
> configure.ac:44: warning: AC_OUTPUT should be used without arguments.
> configure.ac:44: You should run autoupdate.
>    debian/rules override_dh_auto_configure
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> cd tools && ./regenerate
> rm: cannot remove '../Makefile': No such file or directory
> rm: cannot remove '../src/Makevars': No such file or directory
> configure.ac:44: warning: AC_OUTPUT should be used without arguments.
> configure.ac:44: You should run autoupdate.
> configure.ac:44: warning: AC_OUTPUT should be used without arguments.
> configure.ac:44: You should run autoupdate.
>
>
> This results later in:
>
>
> ** using staged installation
> configure.ac: starting
> ./configure: line 1764: syntax error near unexpected token `;;'
> ./configure: line 1764: ` as_dir=./ ;;'
> ERROR: configuration failed for package ‘ncdf4’
>
>
>
> I checked the resulting configure file and the part in question looks like:
>
>
> echo "configure.ac: starting"
>
>  as_dir=./ ;;
>     */) ;;
>     *) as_dir=$as_dir/ ;;
>   esac
>     for ac_exec_ext in '' $ac_executable_extensions; do
>   if as_fn_executable_p "$as_dir$ac_word$ac_exec_ext"; then
>     ac_cv_prog_HAS_NC_CONFIG="yes"
>     printf "%s\n" "$as_me:${as_lineno-$LINENO}: found 
> $as_dir$ac_word$ac_exec_ext" >&5
>     break 2
>   fi
> done
>
>
> It looks like a case statement intended but not injected by autoconf.  I
> have no idea how this can be influenced by some configure.ac statement.
>
> Kind regards
>
>        Andreas.
>
> [1] https://bugs.debian.org/978891

Try this patch.

J.

From 2e5bda24d3b2799d21b5342290fbeed54cf83101 Mon Sep 17 00:00:00 2001
From: Jeremy Sowden <jer...@azazel.net>
Date: Wed, 8 Sep 2021 14:50:40 +0000
Subject: [PATCH] Quote allowed M4 pattern.

Signed-off-by: Jeremy Sowden <jer...@azazel.net>
---
 tools/configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/configure.ac b/tools/configure.ac
index 7d781c514c2e..16579d35a8ab 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -2,7 +2,7 @@ AC_INIT(src/Makevars.in)
 
 echo "configure.ac: starting"
 
-m4_pattern_allow(AC_PATH_NETCDF)
+m4_pattern_allow([AC_PATH_NETCDF])
 
 : ${R_HOME=`R RHOME`}
 if test -z "${R_HOME}"; then
-- 
2.33.0

signature.asc
Description: PGP signature