Manuel, The package is in pretty good shape. I just have a few questions that shouldn’t be too difficult.
THINGS THAT NEED TO BE ADDRESSED BEFORE SPONSORSHIP 1. Your debian/control file specifies: Rules-Requires-Root: binary-targets This is used when the binary targets require root during build time (as contrasted with install time). It is quite rare to need this. If your program does need root during build time that is fine. But I would like to understand why before sponsoring the package. 2. Your debian/postinst creates: /home/$install_user/.config/baby/baby.conf at installation time. Typically this is done at runtime. Otherwise, only the person who installs the package will have the file created. Other users on the system will not. I would recommend that you move the logic for creating this file to your runtime program, so that any user who runs the program will have ~/.config/baby/baby.conf created. If for some reason I have misunderstood what is happening, just explain it to me and I can sponsor it as currently packaged. 3. Your debian/upstream/metadata contains four of the same URLs, and they point to the Debian packaging repository. These should point to the upstream repository, and it would be nice if they were more direct, like this: Bug-Database: https://github.com/manuwarfare/baby/issues Bug-Submit: https://github.com/manuwarfare/baby/issues/new Repository: https://github.com/manuwarfare/baby.git Repository-Browse: https://github.com/manuwarfare/baby COMMENTS THAT DON’T NEED TO BE ADDRESSED BEFORE SPONSORSHIP 1. Your debian/sources contains both options and local-options with similar content. Looking at the instructions it would appear that you only need options. https://www.debian.org/doc/manuals/maint-guide/dother.en.html#sourcel But if for some reason you need both that is OK. 2. You have debian/baby.install, which works fine. If you have multiple binaries you use binary-name.install for each install file. But as you have only one binary, you can just use debian/install if you like. On Friday, July 26, 2024 6:53:22 PM MST Manuel Guerra wrote: > Hi Phil and Soren > > Thanks for your kind words Soren, but I'm afraid that without Phil's > support I wouldn't have been able to get to this point > > In this last upload I've added the link to the packaging files to my > control file > > > I am not able to find the repository of your packaging code.
signature.asc
Description: This is a digitally signed message part.
