control: tags 1072226 - moreinfo
Hi,
Le 2024-07-28 06:34, Tobias Frost a écrit :
Control: tags -1 moreinfo
Hi,
a short review:
- You're repacking the source. It's not clear to me why you are
removing the
files. Can you expand?
The removed files basically falls down into 4 categories:
- useless game config files (they will be recreated if they do not
exist)
- useless .exe win32 binaries
- files without license (no GPL header, nothing)
- useless sources for win32 only application (the levels editor, etc)
My reasoning was: the less files the quicker it will pass the FTP-master
license check
- d/patches: (more a hint, as maintaining patches in Debian will cause
extra
work down the road for you…):
Please consider upstream the patches, the write-to-userdir and the
use-system-zlib might be candidates. As serious-source is using
CMake, the
use-system-zlib patch could be rewritten that CMake is looking for
the system's
zlib, and if it is found use that, otherwise add the bundled zlib to
the include
path. (For illustration, I did something similar recently:
https://github.com/codereader/DarkRadiant/pull/43)
Upstream is basically dead, the last patches are already from me
https://github.com/ptitSeb/Serious-Engine/commits/master/
I have already put too much efforts since 14 months trying to get that
engine into Debian, I will not do anything more that is code-related
unless the engine effectively lands into the Debian archive.
I will resume my efforts once I know it will not be for nothing.
- (Another hint) Please upstream the manpages.
- What is the copyright of the logos (debian/*svg)? Where are they
from?
That's a point i'm less comfortable to answer :-/
Technically, I created them with Inkscape.
But it's based on the official logo, that already exist in a vector
format (that's why the proportions are exactly the same, i copied the
numbers).
So while it's not a direct copy/past, it's not clear to me if I can
claim any copyright at all (or if I was even allowed to create this
"derivative work"?)
- (optional) Please add a repository for the packaging on salsa, maybe
even under
the games team umbrella? (I can create one for you, if you want to go
that route.)
It already exists:
https://salsa.debian.org/twolife/serious-engine
The README says:
Running
-------
This version of the engine comes with a set of resources
(`\SE1_10.GRO`) that
allow you to freely use the engine without any additional resources
required.
However if you want to open or modify levels from Serious Sam Classic:
The
First Encounter or The Second Encounter (including most user-made
levels), you
will have to copy the game's resources (.GRO files) into the engine
folder. You
can buy the original games on Steam, as a part of a bundle with
Serious Sam
Revolution ( http://store.steampowered.com/app/227780 )
- Are the resources mentioned redistributeable or even DFSG licensed?
As far as i can tell, the 'SE1_10.GRO' file is basically
freeware/no-real-licence.
It's a zip file containing countless audio/textures files, without
source nor any licence indication.
Certainly not distributed under any DFSG licenses.
- The README also mentions level editors. Do they compile for linux?
Only the engine builds on Unix/SDL-supported systems.
The other tools are MFC/ms-windows only.
I hope I answered all your questions
br,
Sébasten
If both could be answered yes, your package could go into main.
--
tobi
