Control: tags -1 +moreinfo Tim,
This package has had no feedback from Debian contributors since your last
upload. I will change that now.
Preamble...
Thank you for taking the time to prepare this package and your contribution
to the Debian project.
The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.
Review...
1. Build:
* pbuilder [1]: Issue
dh_auto_test
make -j22 test
make[1]: Entering directory '/build/mongovi-2.0.0'
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-
map=/build/mongovi-2.0.0=. -fstack-protector-strong -fstack-clash-protection
-Wformat -Werror=format-security -fcf-protection -std=c17 -Wall -Wextra -
pedantic-errors -I/usr/include/libbson-1.0 -I/usr/include/libmongoc-1.0 -
DVERSION_MAJOR=2 -DVERSION_MINOR=0 -DVERSION_PATCH=0 -o testshorten
test/shorten.c
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-
map=/build/mongovi-2.0.0=. -fstack-protector-strong -fstack-clash-protection
-Wformat -Werror=format-security -fcf-protection -std=c17 -Wall -Wextra -
pedantic-errors -I/usr/include/libbson-1.0 -I/usr/include/libmongoc-1.0 -
DVERSION_MAJOR=2 -DVERSION_MINOR=0 -DVERSION_PATCH=0 -o testprefixmatch
test/prefix_match.c strlcpy.o reallocarray.o
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-
map=/build/mongovi-2.0.0=. -fstack-protector-strong -fstack-clash-protection
-Wformat -Werror=format-security -fcf-protection -std=c17 -Wall -Wextra -
pedantic-errors -I/usr/include/libbson-1.0 -I/usr/include/libmongoc-1.0 -
DVERSION_MAJOR=2 -DVERSION_MINOR=0 -DVERSION_PATCH=0 -o testparsepath
test/parse_path.c
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-
map=/build/mongovi-2.0.0=. -fstack-protector-strong -fstack-clash-protection
-Wformat -Werror=format-security -fcf-protection -std=c17 -Wall -Wextra -
pedantic-errors -I/usr/include/libbson-1.0 -I/usr/include/libmongoc-1.0 -
DVERSION_MAJOR=2 -DVERSION_MINOR=0 -DVERSION_PATCH=0 -o testjsonify
test/jsonify.c jsmn.o
./testshorten
FAIL: 한 2 = exit: -1, expected: 2
FAIL: 한 3 = exit: -1, expected: 2
FAIL: 한한 2 = exit: -1, expected: 2
FAIL: 한한 3 = exit: -1, expected: 2
FAIL: 한한 4 = exit: -1, expected: 4
FAIL: 한한한한 4 = exit: -1, expected: 4
FAIL: 한한한한 5 = exit: -1, expected: 4
FAIL: 한한한한 6 = exit: -1, expected: 6
FAIL: 한한한한 7 = exit: -1, expected: 6
FAIL: 한한한한 8 = exit: -1, expected: 8
FAIL: £ 2 = exit: -1, expected: 1
FAIL: £한 2 = exit: -1, expected: 2
FAIL: £한 3 = exit: -1, expected: 3
FAIL: £한한 2 = exit: -1, expected: 2
FAIL: £한한 3 = exit: -1, expected: 3
FAIL: £한한 4 = exit: -1, expected: 3
FAIL: £한한 5 = exit: -1, expected: 5
FAIL: 한£ 2 = exit: -1, expected: 2
FAIL: 한£ 3 = exit: -1, expected: 3
FAIL: 한한£ 2 = exit: -1, expected: 2
FAIL: 한한£ 3 = exit: -1, expected: 3
FAIL: 한한£ 4 = exit: -1, expected: 3
FAIL: 한한£ 5 = exit: -1, expected: 5
FAIL: £ह€한𐍈＄ 4 = exit: -1, expected: 4
FAIL: £ह€한𐍈＄ 5 = exit: -1, expected: 5
FAIL: £ह€한𐍈＄ 6 = exit: -1, expected: 6
FAIL: £ह€한𐍈＄ 7 = exit: -1, expected: 7
FAIL: £ह€한𐍈＄ 8 = exit: -1, expected: 8
FAIL: £ह€한𐍈＄£ह€한𐍈＄ ＄ 8 = exit: -1, expected: 8
FAIL: £＄ह€ 한𐍈＄£ह€한𐍈＄ 8 = exit: -1, expected: 8
FAIL: ＄ £ह€한𐍈＄£ह€한𐍈＄ 8 = exit: -1, expected: 8
FAIL: ＄£ह€ 한𐍈＄£ह€한𐍈＄ 8 = exit: -1, expected: 8
FAIL: ＄£ह€ 한𐍈＄£ह€한𐍈＄ 9 = exit: -1, expected: 9
FAIL: ＄£ह€ 한𐍈＄£ह€한𐍈＄ 10 = exit: -1, expected: 10
FAIL: ＄£ह€ 한𐍈＄£ह€한𐍈＄ 11 = exit: -1, expected: 11
FAIL: ＄£ह€ 한𐍈＄£ह€한𐍈＄ 12 = exit: -1, expected: 12
FAIL: ＄£ह€ 한𐍈＄£ह€한𐍈＄ 13 = exit: -1, expected: 13
FAIL: ＄£ह€ 한𐍈＄£ह€한𐍈＄ 14 = exit: -1, expected: 13
FAIL: ＄£ह€ 한𐍈＄£ह€한𐍈＄ 15 = exit: -1, expected: 15
All UTF-8 tests failed, make sure your locale supports UTF-8.
Try: LC_CTYPE=C.UTF-8; export LC_CTYPE
make[1]: *** [Makefile:51: test] Error 39
make[1]: Leaving directory '/build/mongovi-2.0.0'
dh_auto_test: error: make -j22 test returned exit code 2
make: *** [debian/rules:10: build] Error 255
dpkg-buildpackage: error: debian/rules build subprocess returned exit status
2
I: copying local configuration
E: Failed autobuilding of package
I: unmounting dev/ptmx filesystem
I: unmounting dev/pts filesystem
I: unmounting dev/shm filesystem
I: unmounting proc filesystem
I: unmounting sys filesystem
I: cleaning the build env
I: removing directory /var/cache/pbuilder/build/35029 and its subdirectories
philwyett@ks-tarkin:~/Development/builder/debian/mentoring$
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
E: mongovi changes: unreleased-changes
N:
N: The distribution in the Changes field copied from debian/changelog
N: indicates that this package was not intended to be released yet.
N:
N: Please refer to Bug#542747 for details.
N:
N: Visibility: error
N: Show-Always: no
N: Check: fields/distribution
N:
N:
W: mongovi: changelog-distribution-does-not-match-changes-file unreleased !=
unstable [usr/share/doc/mongovi/changelog.Debian.gz:1]
N:
N: The target distribution in the most recent entry in this package's
N: debian/changelog file does not match the target in the generated
.changes
N: file.
N:
N: This may indicate a mistake in setting the distribution, an accidental
N: upload to unstable of a package intended for experimental, or a mistake
in
N: invoking sbuild(1).
N:
N: Please refer to Bug#906155 and the sbuild(1) manual page for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/changelog
N:
N:
W: mongovi source: no-debian-changes
N:
N: This non-native package makes no changes to the upstream sources in the
N: Debian-related files.
N:
N: Maybe a mistake was made when the upstream tarball was created, or maybe
N: this package is really a native package but was built non-native by
N: mistake.
N:
N: Debian packaging is sometimes maintained as part of upstream, but that
is
N: not recommended as best practice. Please make this package native, if
the
N: software is only for Debian. Otherwise, please remove the debian
directory
N: from upstream releases and add it in the Debian packaging.
N:
N: Format 1.0 packages are subject to the restriction that the diff cannot
N: remove files from the debian directory. For Format 3.0 packages, the
N: debian directory is automatically purged during unpacking.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: files/artifact
N: Renamed from: empty-debian-diff
N:
N:
I: mongovi: hardening-no-fortify-functions [usr/bin/mongovi]
N:
N: This package provides an ELF binary that lacks the use of fortified libc
N: functions. Either there are no potentially unfortified functions called
by
N: any routines, all unfortified calls have already been fully validated at
N: compile-time, or the package was not built with the default Debian
N: compiler flags defined by dpkg-buildflags. If built using dpkg-
buildflags
N: directly, be sure to import CPPFLAGS.
N:
N: NB: Due to false-positives, Lintian ignores some unprotected functions
N: (e.g. memcpy).
N:
N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
N:
N:
I: mongovi source: out-of-date-standards-version 4.5.1 (released 2020-11-17)
(current is 4.7.0)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider
updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you
don't
N: have to re-upload the package just to adjust the Standards-Version
control
N: field. However, please remember to update this field next time you
upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
N:
E: Lintian run failed (runtime error)
3. Licenses [4]: Hint
philwyett@ks-tarkin:~/Development/builder/debian/mentoring/mongovi-2.0.0$ lrc
en: Versions: recon 2.0 check 3.3.9-1
Parsing Source Tree ....
Reading d/copyright ....
Missing Files: Paragraph for debian/
4. Watch file [uscan --force-download]:
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Issue - See 1.
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Not performed at this time.
8. Upgrade [Over previous installs if any]: N/A
Summary...
I believe mongovi is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the raised issues.
Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.
If you no longer wish to pursue getting the package into Debian, please could
you close this RFS bug or indicate to me that you wish it closed and I will
do it.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Internet Relay Chat (IRC): kathenas
Matrix: #kathenas:matrix.org
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Threads: https://www.threads.net/@kathenasorg
--
signature.asc
Description: This is a digitally signed message part
