Control: tags -1 +confirmed
On Tue, 10 Jun 2025 10:14:08 +0200 Roland Hieber <[email protected]> wrote: > Control: tags -1 -moreinfo > > On Sat, Jun 07, 2025 at 09:04:23AM +0100, Phil Wyett wrote: > > Summary > > ======= > > > > Looking very good, nice work, with just one issue I can see. > > > > 'debian/rules': Hardening[1] should be done at the top of the file e.g. > > > > export DEB_BUILD_MAINT_OPTIONS = hardening=+all > > > > %: > > dh $@ > > > > [1] https://wiki.debian.org/Hardening > > Ah yes, thanks for the reminder! Previously I had lintian warnings that the > hardening flags were not picked up in dh when I did it globally, but I have now > figured out how to do that correctly :D (Turns out, GNU make does not have a > concept of strings unlike the underlying shell, so I simply had to remove the > quotes in the variable assignment…) > > New package is in the upload queue on mentors, and Git is pushed to Salsa
