On 2004-05-04 Bartosz Fenski aka fEnIo <[EMAIL PROTECTED]> wrote:
[...]
> 2) csmash - a table tennis simulation game
> I've fixed one outstanding bug and I like this game very much ;)
[...]
Hello,
I have taken a short peek at this one and have some
questions/critizism:
#1 I've compared -2 and -3 with interdiff and realized that you have
dumped the patch to loadparts.cpp. Why? I do not speak C++ but afaict
this will reopen #141921.
#2 The generation of the arch all part in debian/rules is broken. You
generate it in in the binary-arch target, and therefore all the
buildds will uselessly build it (check dpkg-buildpackage -B). You have
to generate it in the binary-all target. - Basically you just copy all
the commands listed in binary-arch to binary-all, and add -a to all
debhelper invocations in binary-arch and -i to all in binary-indep and
throw out the unnecesary ones.
#3 You might want to update config.(sub|guess) from autotools-dev
while you are at it.
thanks, cu andreas
--
"See, I told you they'd listen to Reason," [SPOILER] Svfurlr fnlf,
fuhggvat qbja gur juveyvat tha.
Neal Stephenson in "Snow Crash"
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
