On 2004-05-04 Bartosz Fenski aka fEnIo <[EMAIL PROTECTED]> wrote: > On Tue, May 04, 2004 at 10:46:50PM +0200, Andreas Metzler wrote: > > > 2) csmash - a table tennis simulation game > > > I've fixed one outstanding bug and I like this game very much ;) > > [...] > > I have taken a short peek at this one and have some > > questions/critizism:
> First of all thanks for your suggestions and interest. > > #1 I've compared -2 and -3 with interdiff and realized that you have > > dumped the patch to loadparts.cpp. Why? I do not speak C++ but afaict > > this will reopen #141921. > Hmm... well... I haven't dumped anything. Especially patches. > Which versions have you compared? > I started working with `apt-get source csmash` and there are no patches > in debian subdirectory. [...] It is not impossible that I made a mistake, but I simply fetched -2 from Debian and -3 from your site and compared the results: [EMAIL PROTECTED]:/tmp/csmash$ dpkg-source -x csmash_0.6.6-2.dsc ; mv \ csmash-0.6.6 csmash-0.6.6-2 ; dpkg-source -x csmash_0.6.6-3.dsc ; mv \ csmash-0.6.6 csmash-0.6.6-3 ; md5sum *diff* dpkg-source: extracting csmash in csmash-0.6.6 dpkg-source: extracting csmash in csmash-0.6.6 6d3321181513219fc3d6acb65a341201 csmash_0.6.6-2.diff.gz e79fea7a83dbb824f4d9b72dae260c26 csmash_0.6.6-3.diff.gz [EMAIL PROTECTED]:/tmp/csmash$ diff -Nur csmash-0.6.6-2 csmash-0.6.6-3 | lsdiff csmash-0.6.6-2/debian/changelog csmash-0.6.6-2/debian/control csmash-0.6.6-2/debian/copyright csmash-0.6.6-2/debian/csmash-data.dirs csmash-0.6.6-2/debian/csmash.dirs csmash-0.6.6-2/debian/csmash.docs csmash-0.6.6-2/debian/csmash-icon.xpm csmash-0.6.6-2/debian/csmash.menu csmash-0.6.6-2/debian/csmash.xpm csmash-0.6.6-2/debian/rules csmash-0.6.6-2/loadparts.cpp [EMAIL PROTECTED]:/tmp/csmash$ diff -Nur csmash-0.6.6-2 csmash-0.6.6-3 | filterdiff -i csmash-0.6.6-2/loadparts.cpp --- csmash-0.6.6-2/loadparts.cpp 2004-05-04 23:32:45.000000000 +0200 +++ csmash-0.6.6-3/loadparts.cpp 2003-11-19 17:49:31.000000000 +0100 @@ -245,11 +245,7 @@ while ('\\' == line[l-1]) { // concat next line(s) -#if (defined __ia64__) || (defined __alpha__) || (defined __s390__) - int bufsize = clamp((u_long) 0, sizeof(line)-l, sizeof(line)-1); -#else int bufsize = clamp(0U, sizeof(line)-l, sizeof(line)-1); -#endif fgets(&line[l-2], bufsize, fp); if (feof((FILE*)fp)) break; l = strlen(line); You dumped this patch. cu andreas -- "See, I told you they'd listen to Reason," [SPOILER] Svfurlr fnlf, fuhggvat qbja gur juveyvat tha. Neal Stephenson in "Snow Crash" -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]