Control: tags -1 +moreinfo
Hello,
It looks like you are missing at least these entries in debian/copyright:
src/core/parser.tab.c: Copyright (C) 1984, 1989-1990, 2000-2015, 2018-2021
Free Software Foundation,
src/core/parser.tab.h: Copyright (C) 1984, 1989-1990, 2000-2015, 2018-2021
Free Software Foundation,
include/noct/c89compat.h: * Copyright (c) 1996-2024 Keiichi Tabata
Please add those.
Additionally, could you address this Lintian output?
Running lintian...
N:
I: noct source: older-debian-watch-file-standard 4 [debian/watch]
N:
N: The version= line in the debian/watch file in this package declares an
N: older version. Please upgrade when you have a chance.
N:
N: Please refer to the uscan(1) manual page for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/watch/standard
N:
N:
P: noct source: package-uses-old-debhelper-compat-version 13
N:
N: This package uses a debhelper compatibility level that is no longer
N: recommended. Please consider using the recommended level.
N:
N: For most packages, the best way to set the compatibility level is to
N: specify debhelper-compat (= X) as a Build-Depends in debian/control. You
N: can also use the debian/compat file or export DH_COMPAT in debian/rules.
N:
N: If no level is selected debhelper defaults to level 1, which is
N: deprecated.
N:
N: Please refer to the debhelper(7) manual page for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debhelper
N:
N:
X: noct source: debian-watch-does-not-check-openpgp-signature [debian/watch]
N:
N: This watch file does not specify a means to verify the upstream tarball
N: using a cryptographic signature.
N:
N: If upstream distributions provides such signatures, please use the
N: pgpsigurlmangle options in this watch file's opts= to generate the URL of
N: an upstream OpenPGP signature. This signature is automatically downloaded
N: and verified against a keyring stored in debian/upstream/signing-key.asc
N:
N: Of course, not all upstreams provide such signatures but you could request
N: them as a way of verifying that no third party has modified the code after
N: its release (projects such as phpmyadmin, unrealircd, and proftpd have
N: suffered from this kind of attack).
N:
N: Please refer to the uscan(1) manual page for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/watch
N: Renamed from: debian-watch-does-not-check-gpg-signature
N: debian-watch-may-check-gpg-signature
N: This tag is experimental.
N:
I: Lintian run successful (worst tag: info)
Once you're ready for another review, please remove the moreinfo tag. Feel free
to CC me, if I'm available I can take another look.
Best regards,
Simon Quigley
[email protected]
