On 7/7/07, Nicholas Jefferson <[EMAIL PROTECTED]> wrote:
http://mentors.debian.net/debian/pool/main/i/inferno/inferno_0.0.20070510-2.diff.gz
No time to sponsor, but some comments:
* consider putting the patches into quilt (or maybe dpatch)
* that is a lot of patches to the font stuff, what are they for?
(quilt/dpatch patches can have this info in the header). Perhaps you
could replace that with a script to ease migration of the patches to
the next upstream release
* don't forget to send patches and manual pages upstream if you
haven't already. If the patches are just hacks to workaround upstream
problems, please fix those problems and send patches upstream.
* what is the deal with all the lintian overrides?
* rules/postinst/etc contain unneeded comments
* add homepage to the package descriptions ' Homepage: <url>'
* any reason for the -bin package to be not arch any?
* might want to modify the get-orig-source target so you don't have to
change the version number 10 times
* might want to use --rsyncable when compressing the tarball
* might want to use dh_install & dh_installdirs instead of cp/mkdir
* debian/rules contains bashisms - {}
* I see upstream contain an embedded freetype code copy, is it
compiled into the package? if so, please notify the debian security
team (once inferno is uploaded) so they can track vulnerabilities
better, and add the copyright info for freetype to debian/copyright.
* I suspect you haven't gone through every file looking for copyright
information, please read
http://lists.debian.org/debian-devel-announce/2003/12/msg00007.html
and http://lists.debian.org/debian-legal/2003/12/msg00194.html
--
bye,
pabs
http://wiki.debian.org/PaulWise
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
