On Thu, Nov 08, 2007 at 03:59:44PM +0100, Bas Wijnen wrote: > On Thu, Nov 08, 2007 at 08:22:06PM +0530, Kumar Appaiah wrote: > > On Thu, Nov 08, 2007 at 03:24:40PM +0100, Bas Wijnen wrote:
> > > I wouldn't do that. Repackaging is done to make the tarball complient > > > with our standards, not to beautify it. If this conversion is a good > > > idea (and I agree that it is), then that is an upstream issue, and it > > > should be fixed there. Asking them about it is a good idea, changing it > > > in the package is not IMO. > > > > I had to do this, because this caused some build failed for some > > reason (I don't recall, but my mentor asked me to do it). > > Making changes to make the build work is always good, of course. > However, when changes are made for the Debian package, this should be > done in a way which doesn't hide them. When a user sees a package where > the tarball is repackaged "because some files had to be removed", she's > not going to expect any changes other than the removal of some files. > For other changes, we have a nicely working patch system. In fact devref 6.7.8.2.2 discourages doing anything except removing files when repackaging. Justin -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]