On Thu, Mar 13, 2008 at 10:31:31PM +1100, Jack Coulter wrote: > Dear mentors, > Hi,
Just some remarks: You're archive is not clean: $tar tf urbanterror-data_4.1.tar.gz| grep tmp urbanterror-data-4.1/tmp.wSEBJ15633/ urbanterror-data-4.1/tmp.ZDDmV19344/ urbanterror-data-4.1/tmp.OAewO17038/ Lintian also generates some warnings: W: urbanterror-data: malformed-title-in-templates urbanterror-data/license W: urbanterror-data: too-long-extended-description-in-templates urbanterror-data/license W: urbanterror-data: missing-debconf-dependency-for-preinst About the preinst script: You package should depend on debconf, unzip, wget and zenity since you use them. You can't be sure the dependency will be correctly installed without a Pre-Depends fields. Take a look on Debian Policy 7.2, IMO you should do a postinst instead. The binary-common section of your rules file is useless. The -a parameter used with debhelpers is also useless since you build just one archindep package. The get-orig-source: seems to be useless too. You don't need the upstream archive for the build. Cheers, Gonéri
signature.asc
Description: Digital signature