On Mon, Feb 16, 2009 at 5:34 PM, Jens Peter Secher <jpsec...@diku.dk> wrote: > The package looks good, except for a few things:
Thanks for you review. Now, please see my comments below: > - The Depends for libjabberd2-dev should be > libjabberd2 (= ${binary:Version}). Solved. > - /var/spool/jabberd (and old /var/lib/jabber) is not deleted on > purge. Should it be? In any case, if a user is upgrading from a > system with /var/lib/jabber, then uninstalls the package, and then > reinstalls it, the old /var/lib/jabber will overwrite the new > contents of /var/spool/jabberd which does not seem like a good idea. Well, I think that information on /var/lib/jabber or /var/spool/jabberd should not be deleted automatically on purge since in those folders are stored the information of users registered on a jabberd14 server. I would prefer the admin delete this information manually if necessary. To solve the uninstall problem that you indicated, I did the following change: --- jabberd14-1.6.1.1/debian/jabberd14.postinst +++ jabberd14-1.6.1.1/debian/jabberd14.postinst @@ -37,8 +37,9 @@ # Correct the permissions. chown jabberd:jabberd /etc/jabber/jabber.xml chown jabberd:jabberd /var/run/jabberd/ - # copy /var/lib/jabber to /var/spool/jabberd if it exists - if [ -d /var/lib/jabber ]; then + # content of /var/lib/jabber is copied to /var/spool/jabberd only if + # latter doesn't exist + if ! [ -e /var/spool/jabberd ] && [ -d /var/lib/jabber ]; then cp -a /var/lib/jabber/* /var/spool/jabberd fi chown -R jabberd:jabberd /var/spool/jabberd/ What do you think about that? Is a correct way to avoid the uninstall problem? > And then the nitpicks: > > - There is no need to have usr/bin, usr/sbin, /usr/lib and > /usr/include in *.dirs files. Done. I simplified those *.dirs files. > - Any particular reason for using old debhelper compatibility version > 4? Not really. I set debhelper compatibility version to 5. A new version for this package is available at: http://mentors.debian.net/debian/pool/main/j/jabberd14/jabberd14_1.6.1.1-1.1.dsc Regards, PD: now the package have a lintian warning: W: jabberd14 source: maintainer-upload-has-incorrect-version-number 1.6.1.1-1.1 However, I think this is not a problem because if this package get uploaded to sid, its version would be 1.6.1.1-1, right? -- Miguel Landaeta, miguel at miguel.cc secure email with PGP 0xBBAE1769 available at http://keyserver.pgp.com/ "Faith means not wanting to know what is true." -- Nietzsche -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org