-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/31/2010 01:00 AM, Benjamin Drung wrote: > I did a quick review: > > 1) Please rename the source package to ubiquity-extension (or Done
> 2) You use features of mozilla-devscripts 0.22 [2]. Please adjust the > Build-Depends. Done > 3) "${xpi:Recommends} (>= 3.6)" doesn't work, because multiple items > could be generated. If you want versioned Recommends, mozilla-devscripts > needs to be adjusted. It generates "Recommends: iceweasel (>= 3.6)" which seems to be ok. What multiple items do you mean in this case? > 4) Don't rely on the installation destination of install-xpi (run by > dh_auto_install). It may change in the future. Run "install-xpi > -i /usr/share/xul-ext/$(NAME) [...]" instead of dh_auto_install. Done > 5) You may be interested in xpi-repack to get rid of the get-orig-source > rule (more details in the man page). Done Thanks for your review. Gabriele -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkzMvX0ACgkQp3cdCbVcnCvKdACfYHObJYsDFJxcyx6CGlOzzvFt EdAAn0juN5EnELIdC0T3gBjM5vgOLXsT =euL/ -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4cccbd7d.6000...@gmail.com