Thanks, Benoit now I have some things to fix :-) (my debuild-called lintian said nothing, so I thought it is okay)
Kind regards, Chris Benoît Knecht wrote: > Benoît Knecht wrote: >> Hi Christian, >> >> Christian Pohl wrote: >> > I am looking for a sponsor for my package "webhoneypot". >> > >> > * Package name : webhoneypot >> > Version : 0.1.123 >> > Upstream Author : Johannes Ulrich <jullrich_at_sans_dot_edu> >> > * URL : http://code.google.com/p/webhoneypot/ >> > * License : GPL-2 >> > Section : web >> > >> > It builds these binary packages: >> > webhoneypot - DShield Web Honeypot Project >> > >> > The upload would fix these bugs: 595907 >> >> I didn't look at your package yet, but lintian reports a few issues that >> you should definitely fix: >> >> I: webhoneypot source: missing-debian-source-format >> P: webhoneypot source: direct-changes-in-diff-but-no-patch-system >> apache/webhoneypot and 5 more >> I: webhoneypot source: no-complete-debconf-translation >> I: webhoneypot source: debian-watch-file-is-missing >> W: webhoneypot source: non-native-package-with-native-version >> W: webhoneypot source: debhelper-but-no-misc-depends webhoneypot >> W: webhoneypot source: dh-clean-k-is-deprecated >> W: webhoneypot source: out-of-date-standards-version 3.8.0 (current is >> 3.9.1) >> >> You can get a detailed description of these messages by running: >> >> lintian -iI --pedantic webhoneypot_0.1.123.dsc > > OK, so I had a closer look at your package, and here are a few more > comments: > > - lintian reports these warnings on the binary package (run > lintian -iI --pedantic webhoneypot_0.1.123_${arch}.deb > for details): > I: webhoneypot: unused-debconf-template > webhoneypot/note_enable_apache_config > I: webhoneypot: using-first-person-in-description line 5: we > I: webhoneypot: using-first-person-in-description line 5: We > I: webhoneypot: using-first-person-in-description line 7: We > I: webhoneypot: using-first-person-in-description line 7: we > I: webhoneypot: using-first-person-in-description line 8: we > I: webhoneypot: using-first-person-in-description line 9: we > I: webhoneypot: copyright-with-old-dh-make-debian-copyright > W: webhoneypot: script-not-executable > ./usr/share/webhoneypot/update/update-templates.php > P: webhoneypot: maintainer-script-without-set-e config > W: webhoneypot: package-contains-upstream-install-documentation > usr/share/doc/webhoneypot/INSTALL.gz > > - Your debian/rules file could be greatly simplified if you make use of > debhelper's default behavior. For example, you can use a > debian/install file and let dh_install copy the files automatically > instead of overriding the install target. See [1] and the debhelper > documentation for details. > > [1] http://www.debian.org/doc/maint-guide/ch-dother.en.html > > - I'm not very familiar with debconf, but it doesn't seem like you're > doing anything with it in debian/{pre,post}inst. If it's intentional, > you should remove those files. The same goes for webhoneypot.config. > > - debian/README.debian should be word wrapped at around 80 chars. > > - Please consider using DEP-5 [2] format for your debian/copyright > file. > > [2] http://dep.debian.net/deps/dep5/ > > I hope this helps. > > Cheers, > > -- > Benoît Knecht > > > -- > To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact > listmas...@lists.debian.org > Archive: http://lists.debian.org/20101116155212.gb7...@debian.lan > > > -- Christian Pohl whpqpohlcity.de -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e627f4ac8f5228877582bb09817ea18e.squir...@aringill