Reuploaded a new version comments online On Thu, Jul 7, 2011 at 5:27 PM, Kilian Krause <kil...@debian.org> wrote: > Hi Bastien, > > On Thu, 2011-07-07 at 07:50 +0200, roucaries bastien wrote: >> Please do not upload directly, i will upload git tree before under >> collab maint and postthe final ppackage here. >> >> It is more a rfc. >> > http://mentors.debian.net/debian/pool/main/a/autoconf-archive/autoconf-archive_2011.04.12-1.dsc > > Comments are: > > 1. debian/autoconf-archive.doc-base.autoconf-archive should most > probably be named debian/autoconf-archive.doc-base > Done
> 2. Me personally I'd prefer seeing that CDBS be ditched in favour of dh I prefer cdbs (taste mater) > 3. your indentation in debian/changelog is somewhat lacking the second > level for your "- " items Done > 4. The version that's on mentors.d.n does FTBFS for me in pbuilder with: Add texinfo as build depend I could not test under pbuilder uml due to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585352 > ------------------(snip)------------------ > make[2]: Entering directory > `/tmp/buildd/autoconf-archive-2011.04.12/doc' > rm -rf autoconf-archive.htp > if /bin/bash /tmp/buildd/autoconf-archive-2011.04.12/build-aux/missing > --run makeinfo --html -I . \ > -o autoconf-archive.htp autoconf-archive.texi; \ > then \ > rm -rf autoconf-archive.html; \ > if test ! -d autoconf-archive.htp && test -d autoconf-archive; then \ > mv autoconf-archive autoconf-archive.html; else mv > autoconf-archive.htp autoconf-archive.html; fi; \ > else \ > if test ! -d autoconf-archive.htp && test -d autoconf-archive; then \ > rm -rf autoconf-archive; else rm -Rf autoconf-archive.htp > autoconf-archive.html; fi; \ > exit 1; \ > fi > /tmp/buildd/autoconf-archive-2011.04.12/build-aux/missing: line 52: > makeinfo: command not found > WARNING: `makeinfo' is missing on your system. You should only need it > if > you modified a `.texi' or `.texinfo' file, or any other file > indirectly affecting the aspect of the manual. The spurious > call might also be the consequence of using a buggy > `make' (AIX, > DU, IRIX). You might want to install the `Texinfo' package or > the `GNU make' package. Grab either from any GNU archive site. > make[2]: *** [autoconf-archive.html] Error 1 > make[2]: Leaving directory `/tmp/buildd/autoconf-archive-2011.04.12/doc' > make[1]: *** [html-recursive] Error 1 > make[1]: Leaving directory `/tmp/buildd/autoconf-archive-2011.04.12' > make: *** [debian/stamp-makefile-build] Error 2 > dpkg-buildpackage: error: debian/rules build gave error exit status 2 > ------------------(snip)------------------ > > 5. As Deng Xiyue has retired, I think it'd be ok to remove him entirely > from the Uploaders field. Done put myself as maintainer and it is Qingning Huo <q...@mayhq.co.uk> that retired. Deng Xiyue is still an uploader (but busy by real life) Bastien > > -- > Best regards, > Kilian > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAE2SPAYEugfNzejOG8dkHVRYo=o8mdwoadho+g0qcgtmk-o...@mail.gmail.com