Hi Andrew, [ I prefer to have a bumped package version after an each review ]
My review: ------- libbs2b ------- 1) there is definitely something wrong with remove_win32_build_instruction patch, its size is more than 2 MiB and it includes some autotools stuff; 2) Vcs-* fields point to LADSPA plugin repository; 3) debian/copyright: 3.1) there is no m4/pkg.m4 source file; 3.2) build-aux/* copyright years should be at least 1996-2010; 3.3) aclocal.m4, */Makefile.in: is automatically generated, does not need the entry; 3.4) configure: copyright years should be 1992-2010. I didn't yet attempt to build it because of 1). ----------- bs2b-ladspa ----------- 1) it can be uploaded only after libbs2b is accepted to the archive; 2) debian/copyright: 2.1) s!Files: *!Files: src/plugin.c! ; 2.2) spurious 'Copyright 2009 Boris Mikhaylov' (copy leftover?); 2.3) same (or about the same) corrections as in libbs2b's debian/copyright. Didn't attempt to build as well because of 1). -- Eugene V. Lyubimkin aka JackYF, JID: jackyf.devel(maildog)gmail.com C++/Perl developer, Debian Developer -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110725094126.GA32055@r500-debian