Hi Kilian, I just uploaded following changes for packages l2tp-ipsec-vpn and l2tp-ipsec-vpn-daemon
- deleted postinst, postrm, prerm (l2tp-ipsec-vpn-daemon) - removed hard coded arch (l2tp-ipsec-vpn, l2tp-ipsec-vpn-daemon) - simplified rules by putting all dependencies into make file (l2tp-ipsec-vpn, l2tp-ipsec-vpn-daemon) - added tests (l2tp-ipsec-vpn) I did not change the daemon path "/usr/lib/l2tp-ipsec-vpn-daemon/L2tpIPsecVpnControlDaemon" to /usr/sbin, because the daemon is supposed to be called only from the GUI. According to http://www.debian.org/doc/packaging-manuals/fhs/fhs-2.3.html#USRLIBLIBRARIESFORPROGRAMMINGANDPA I think this is the right place. Hoping to receive either further reviews or that someone will put the packages into NEW. Thank you and best regards, Werner On 08/03/2011 04:41 PM, Kilian Krause wrote: > Hi Werner, > > On Wed, 2011-08-03 at 16:19 +0200, Werner Jaeger wrote: >> you should be able to find l2tp-ipsec-vpn-daemon package at >> >> http://mentors.debian.net/cgi-bin/maintainer-packages?action=details;package=l2tp-ipsec-vpn-daemon >> >> Repository URL is >> >> http://mentors.debian.net/debian/pool/main/l/l2tp-ipsec-vpn-daemon >> >> So far, this package has got now review yet. >> >> If you find the l2tp-ipsec-vpn-daemon package to be o.k. I'd be happy if >> some one could put both packages into NEW. > the postinst, postrm, prerm aren't used. You may want to delete them. > > debian/rules reads: > make -f nbproject/qt-Release.mk > dist/Release/GNU-Linux-x86/L2tpIPsecVpnControlDaemon > -(snip)- > > Why hard code the arch here? Will this be a problem on any Debian arch > including the kFreeBSD ones? > > As I already said for the GUI - the construction with the extra > nbproject looks a bit weird as you are both upstream and Debian > maintainer. I'm not sure you aren't overcomplicating the debian/rules > file. > > Regarding the test target in debian/rules you've put it for the daemon > and for the GUI yet both times without content. Any reason to add this > line here? Are you planning on adding tests (which would be great) but > they aren't ready despite your 1.0.0 version number? > > I'm not too sure whether > "/usr/lib/l2tp-ipsec-vpn-daemon/L2tpIPsecVpnControlDaemon" is the best > path to put your deamon. I'd see /usr/sbin somewhat more appropriate. > > Other than that good to go IMHO. > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e3ae153.60...@web.de