On Tue, Aug 16, 2011 at 7:31 AM, Hamish <hamis...@yahoo.com> wrote: > Hi, > > it is been a while since our last review of the OpenCPN > packaging, and the stable release we were working towards > has now shipped. Our .deb packaging efforts await further > instructions. > > > source tarball: > http://pkg-grass.alioth.debian.org/tarballs/opencpn_2.5.0+dfsg.orig.tar.gz > > debian/ packaging files: > svn co svn://svn.debian.org/pkg-grass/packages/opencpn/trunk/debian > > earlier review+comments can be found in the ITP: > http://bugs.debian.org/538067 > > > You'll notice our source tarball is labeled dfsg. This is because > there were some included DLLs to help build the MS Windows > version of the program which we didn't need/want for the Linux > build, the source code itself is untouched.
Is the source included for those DLLS? If so, I'm not convinced you need to DFSG repack, but someone else can chime in. I don't think just because upstream uses krufty practices that it should be repacked. Now, if it had a nonfree issue, and while you're in there you cleaned it up, I'm sure that'd be fine. Again, perhaps a DD can chime in. Was the source included for the DLLs? > > With respect to that, the one unanswered question Anton & myself > had was if the version in debian/changelog needed to exactly > match the filename of the source package? i.e. do we need to > include "dfsg" in the version number? Yeah, you do. Lintian should complain if it's wrong. Take a look at the source to Fluxbox, we have a dfsg repack in place. Here's a snippit for you: fluxbox (1.3.1~dfsg1-2) unstable; urgency=low > > I would prefer not to as our build is bit-for-bit identical to > the upstream source distribution, and amending the version number > gives the impression that upstream is somehow not DFSG. There Are they DFSG? Why repack if it's already DFSG? > was some talk that pbuilder had issues with the .orig.tar.gz > version number having to match the final binary package number. > Is there a work around? Does there have to be? (I mean do the > debian buildbots care if the source.orig.tar.gz version exactly > matches?) I am using debuild and don't experience the problem > myself.. > > > thanks, > Hamish > > > -- > To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org > Archive: > http://lists.debian.org/1313494294.19695.yahoomailclas...@web110016.mail.gq1.yahoo.com > > -- All programmers are playwrights, and all computers are lousy actors. #define sizeof(x) rand() :wq -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cao6p2qqdntqk2rmhd08anwnp-goke9dn+yc7xbagcfrgkgz...@mail.gmail.com