On Tue, Nov 22, 2011 at 4:44 PM, Neutron Soutmun wrote: > flvmeta - Metadata injector for FLV video files
The package is already uploaded, but here is a review anyway: http://packages.qa.debian.org/f/flvmeta.html You might want to consider using wrap-and-sort. I think your watch file should use can=1 instead of can=3. In the watch file there needs to be a uversionmangle/dversionmangle set so that versions can be properly compared. You can probably drop the roff documentation from the manual page, lines starting with this: .\" Please forward the manual page upstream if you have not already. In your patches it is customary to set the Forwarded header to the URL where the patch can be found upstream or the email address it was forwarded to. There is one GCC warning: json.c: In function 'json_unescape': json.c:1337:7: warning: format '%llX' expects argument of type 'long long unsigned int', but argument 3 has type 'long unsigned int' [-Wformat] Please modify the debtags for this package: http://debtags.alioth.debian.org/edit.html?pkg=flvmeta Please consider uploading a screenshot of flvmeta in use in a terminal: http://screenshots.debian.net/package/flvmeta -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caktje6fui8hig0_oct4xmjtqtmgv6gnoxh_ceucjqeactqc...@mail.gmail.com
