Dmitry Smirnov wrote:
> > I see... Well, the proper solution would be to separate both packages;
> > right now, the .orig.tar.bz2 file is not at all an upstream archive
> > (it's not even the concatenation of both upstream archives), so of
> > course it makes it impossible to comply with the policy.
> 
> Yes, orig.tar is such a mess... :(
> 
> > It seems like a lot of work for a package that is no longer maintained
> > upstream, but I don't see another way of being policy-compliant.
> 
> True. I don't know why am I doing this but I separated this package into
> two as it should be.

That's great, thanks!

> Please find
> 
>   http://mentors.debian.net/debian/pool/main/r/rsbep/rsbep_0.0.5-1.dsc
> 
> and
> 
>   http://mentors.debian.net/debian/pool/main/d/dvbackup/dvbackup_0.0.4-7.dsc

I've only looked at dvbackup for now:

  - Regarding the version number, I'm not sure the debian version should
    be 7. It's the first debian package with an upstream version of
    0.0.4, so 0.0.4-1 seems appropriate. But again, to be confirmed, I'm
    not familiar with the convention in this (rather unusual) case.

  - There's a typo in your debian/changelog: repackajing -> repackaging.

  - Don't install ChangeLog explicitly, it's automatically installed as
    changelog.gz. ReleaseNotes is also redundant.

  - The example file debian/examples/rundvbackup should be installed in
    /usr/share/doc/dvbackup/examples/.

  - dvbackup.html contains essentially the same information as the man
    page, but starts with a big "dvbackup 0.0.2" header. I would simply
    not install it.

  - I don't think dvbackup should Depend on rsbep; it's not strictly
    required, so Recommends would be more appropriate.

  - In debian/copyright, it would be nicer to use standalone paragraph
    for the GPL-2+, instead of having a short and a long version of the
    license.

  - Regarding copyright, logo.xcf, minilogo.ppm and minilogo.c are (at
    least partly) © Larry Ewing [1].

    [1] http://www.isc.tamu.edu/~lewing/linux/

Cheers, and thanks for your work.

-- 
Benoît Knecht


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20111127171336.ga30...@marvin.lan

Reply via email to