Marco Balmer <ma...@balmer.name> writes:
> I am looking for a sponsor for my package "couriergrey".
[...]
> couriergrey - Mail filter interface of Courier-MTA to support greylisting
[...]
> dget -x
> http://mentors.debian.net/debian/pool/main/c/couriergrey/couriergrey_0.2.2-1.dsc
I had a look at the packaging, but unfortunately, there's a few things
that I find serious enough to not upload the package as-is:
What's with the Depends line?
Depends:
${misc:Depends},${shlibs:Depends},libglibmm-2.4-1c2a,libgdbm3,libpopt0,courier-mta
Why list libglibmm-2.4-1c2a, libgdbm3 and libpopt0 explicitly, when
they're picked up by dh_shlibdeps anyway (and that adds proper version
restrictions too)?
I haven't looked closer, but the m4 build-dependency looks interesting
to me. On a first look, it shouldn't be needed. Granted, it doesn't hurt
much, even if it is not needed, but still.
Your debian/copyright file is also incomplete (and invalid, too):
* There is no separation between the first Source paragraph, and the
Files paragraph.
* It lists the upstream author as the copyright holder for debian/ (you
only have a single Files section, so it applies to everything,
including debian/), which is not the case.
* It lists GPLv3 as the license, while the source headers incidcate
GPLv2+.
* The copyright year (2011) is wrong. According to the source headers,
it should be 2007-2011.
--
|8]
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/871uskqs5l....@luthien.mhp
