I don't intend to sponsor this package, but here is a review: Regarding makefile.patch:
Changing prefix should not be needed, just build/install with make prefix=/usr ... The manpage related changes should be included in manpage.patch instead. The other changes should not be needed if you are running dh_fixperms Regarding manpage.patch: "Origin: upstream" does not make sense when "Forwarded:" is set, please read DEP-3 again: http://dep.debian.net/deps/dep3/ Please send upstream a patch for the Makefile, they are installing the binary without creating $(DESTDIR)$(bindir) first. The dir zinc/ is an embedded code copy, please package that separately: http://tibleiz.net/zinc/ Please use dh --parallel otherwise your package will not comply with policy. When building with DEB_BUILD_OPTIONS=nostrip,noopt the package is still built with optimisation and the debug symbols are still stripped out. Your package fails to build if built twice in a row. You/upstream forgot to clean up after the zinc compilation. cppcheck finds some issues: [samples/files/string.cpp:506]: (error) Mismatching allocation and deallocation: StringBuffer::p [samples/files/string.cpp:514]: (error) Mismatching allocation and deallocation: StringBuffer::p [samples/files/string.cpp:524]: (error) Mismatching allocation and deallocation: StringBuffer::p [zinc/zc.c:2921]: (error) Resource leak: _f_3 [zinc/zc64.c:2921]: (error) Resource leak: _f_3 There are lots of dpkg-shlibdeps warnings. Your debian/copyright file is missing the copyright holders for macospackaging/Script_Exec/. Please ask upstream to port the program to GTK+ 3 since GTK+ 2 will go away at some point. Some of the files have the old address for the FSF, please ask upstream to fix that. gcc warnings: gcc -O2 -fomit-frame-pointer -c -o zc.o zc64.c zc64.c:865:14: warning: conflicting types for built-in function 'malloc' [enabled by default] zc64.c:1246:21: warning: conflicting types for built-in function 'fwrite' [enabled by default] zc64.c: In function '_new_type_p_s__memory_bundle_dw_e__type_id_in_dw_dw': zc64.c:2104:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] zc64.c: In function '_copy_p_vo_p_vo_dw': zc64.c:2311:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] zc64.c: In function '_unexpected_p_s__parser_e__token_p_s__lexeme_e__token': zc64.c:4767:75: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] zc64.c:4767:113: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] zc64.c: In function '_syntax_error_p_s__parser_e__token_p_s__lexeme': zc64.c:4801:69: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ... Compiling zinc files... Compiling generated c file... cb.c:3329:21: warning: conflicting types for built-in function 'fwrite' [enabled by default] cb.c: In function '_resize_p_s__identity_set_dw': cb.c:20887:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] cb.c: In function '_add_p_s__identity_set_p_vo': cb.c:20922:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] cb.c: In function '_clear_p_s_GtkClipboard_p_vo': cb.c:31955:6: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] cb.c: In function '_actual_copy_p_s__text_view': cb.c:32024:148: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] cb.c: In function '_copy_reference_p_s__code_browser_frame_box': cb.c:44830:150: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Linking... lintian complaints: P: code-browser source: unversioned-copyright-format-uri http://dep.debian.net/deps/dep5 P: code-browser: no-upstream-changelog -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKTje6F5EHhWWGvLWfsx0iZh2y3sHc63Nu_=rqbR=Qb=cs2...@mail.gmail.com