-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Anton,
as an update to your review: I've uploaded a new version to mentors
and committed the same packaging files to collab-maint ('revamp'
branch, though). To keep track:
On 02/23/2013 08:02 AM, Anton Gladky wrote:
> 1) Use DEP-3 for patches (at least Description, Author,
> Last-Update). 2) Remove the fix-makefile.patch, which is not listed
> in debian/patch/series
Corrected.
> 3) Changelog-entry #2 is not necessary IMHO.
Hm.. I merged this into the "New maintainer" line. Is there another
place to thank the former maintainer? I kind of like these little
pieces of appreciation. But yeah, it doesn't need to be the changelog.
> 4) Compat 7 should be better changed to the newer 9 as well as BD
> in control. It will allow also to inject hardened buildflags.
I updated to 9.
Just wondering: wheezy ships with dh 8. Why not keep a lower
requirement to allow for easier backports? What benefit does a newer
debhelper compat level give?
> 5) Standards-Version is already 3.9.4
Corrected. (No changes required.)
> 6) As I understood from #583862, there is already a VCS on
> collab-maint, add corresponding fields into control-file.
Added.
> 7) Use in debian/rules dh_auto_configure -- --prefix=........
> instead of "configure". It should be more "nicely"
Very nice hint. Turned out I could skip the entire override.
dh_auto_configure passes --disable-maintainer-mode by default, where
as I used to pass --enable-maintainer-mode. As we don't need to run
autotools anymore, it seems better to disable maintainer-mode, anyway.
> 8) dh 9 sets the "correct" buildflags in many cases. Do you really
> need to set them explicitly?
No, very likely not. Especially as asio doesn't install any binary. So
whatever flags we pass there, they only ever affect the test suite.
Thus, I stripped all custom {CXX,LD}FLAGS and now use the defaults.
> 9) Add --parallel option to dh for faster building.
Added.
> 10) The upload should be targeted to experimental branch due to a
> freeze-period.
Corrected.
Regards
Markus Wanner
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQQcBAEBCgAGBQJRNIYJAAoJEOhoLRs/MemzRUogAMgD81t6LG9eMXtmsojbBzOS
Hg9O8W8IUX2aWVeOpbsu/VDbwNEaEq446yDYsbV36N925EltvtZJmcyNWkLs8LYy
4sb+gPIdYBQqIeS5KV9M1uWIVg0Kpq1P0WcQLWgGl1UheqBGMd1ErHvnGPzzKYXq
i7fKbZq1JhoBVppmNwCLqxIb4wl1BA97rlTmXPTAmu6JCTOg7u81pwArKvwwgnuy
hzwhgnVaC6DuS9z3XMeavKToU5XibLin2o2CEtmzVzRjF2L/rWhaRuilckdn2Hq7
MtDFs2WQMm/1JED1G52GTnqEFfN84gaqxOP3of79eBt0f5KFH9MqiezJtfJrhg34
dBO39IjqlekR9pN+dmdrIFkra+kjdqnY1k6ZWblDk5li4P25prIBkOJZCwijADZ6
ruXrKjJMl9sQ6Bs6FhN7LIo/1H08okaRh1KHI9rbQW354n+LRZsgR38oQM46642c
zpV8OGBQQNBvseHkRBxmkExCh+H2CqR9Xq7koVXC3kdF+uZSpqTqXEhcrRYtjKDE
zXo8gDiq0upQP21oAhZHPXAAJL/5tZCCbssT+chSGbDZbber+ksd4jjdFGJpCEqX
dpJvGcRgDhCYBxWM7fg/KTTfw1kcnDj5rZ1p1B5INN1XFk5sB4vFN4AIYJqFVK/a
wU4lWZpFzABqL1pTZCYwjhF7foY1nkvGDatfqE+r0QSy40c9guVeGBA4d4btRRRV
gMjiUmys0CCQO3B5UzjB1fe1PuKkBEjGEwVo7tVJBfNRoiGw19H+++v6OQPoCDZ6
o5KyTPQ5iFjeTVlyv+5fJmN34AwdlSZQ8fYzO1uruJAVnTE17SY8C6vTkVylOrUx
cLhp8YiniDWh03lHHtoj7zvHNpUQU8B5kHN9wm3aE0TilQOzQg7BV7erqZhIJUgp
+cuBJAi6pr20pR8uhU4MgKgU6ul526M/y/K4YT6b66W4Ffj6aVeS4BhX2/Ic9Qgx
g9e+jvQBvvgJyscD+r7mSHz6pOasFwJ+ZgAmRw5EXBnsPGXWC0EXDuz9pd7xXeuX
I8eOIrWeqc0ZuLHS2S93r0gg4zoTsnE0SCpYlZdNci/0vsG/yAkdBQugKOdwWxYz
tpBBKqj7YN2C1V5ajoW6uMC6IxY/xTEQRSIQMH93BG16ytfH7wZqyKV/yWF+fcja
OWx9pHe5SrNBSiR4soknqWWwmXf7mNEknAdlByPWrMJrrVbe7dpQX7dPsop+7jdh
E36j0ks4vF5Fy7EnX8QQBVI9saaFl4PgxbPfXQ2aR0D5Y/4LLHPzmo84cs73zqLi
DzXQ0CvvFaKqAtkxz0DdDqdbun+z4FkXrzLfUVJgNUXlmNuc3SqCobbZJiYTcCA=
=Mlh2
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/5134860b.7090...@bluegap.ch
