(I don't intend to sponsor this package, sorry.)
* Vern Sun <s5u...@gmail.com>, 2013-03-23, 15:01:
http://mentors.debian.net/package/ranger
A direct link to .dsc would have been helpful:
http://mentors.debian.net/debian/pool/main/r/ranger/ranger_1.6.0-1.dsc
What happened to changelog entry for 1.5.4-1? Also, this change to
1.5.3-1 entry looks unnecessary:
- * New upstream release.
+ * New upstream release
Lintian emits:
I: ranger: unused-override script-not-executable
usr/share/pyshared/ranger/data/ranger
There's also another override:
N: This script is considered a configuration file, so tell lintian to not
N: complain:
O: ranger: script-not-executable usr/share/pyshared/ranger/data/scope.sh
Wait... Configuration files must not reside in /usr. This is a serious
violation of Policy ยง10.7.2.
The manpage says that configuration files "are usually installed to
/usr/lib/python*/dist-packages/ranger/config". Usually installed by
who/what? I first thought that this file was included in the Debian
package, but it's not... And then again, configuration files belong in
/etc, not /usr.
lintian4python emits (among others):
i: ranger source: python-provides-considered-harmful ranger
e: ranger: pyflakes-undefined-name
usr/share/pyshared/ranger/core/loader.py:152: errno
e: ranger: pyflakes-undefined-name
usr/share/pyshared/ranger/core/loader.py:152: errno
(Although in this case it's rather s/harmful/useless/, because nothing
will generate this substitution variable.)
Are Python modules included by this package supposed to by used by other
software? If yes, then the package name should be python-ranger.
Otherwise, they should be moved to a private directory.
Copyright years in debian/copyright don't look up to date. This change
looks wrong:
-Copyright (c) 2009-2012, Roman Zimbelmann <rom...@lavabit.com>
+Copyright (c) 2009-2011, Roman Zimbelmann <rom...@lavabit.com>
Upstream uses sys.version (which is a string) for version comparison.
Please recommend them using sys.version_info (a tuple) instead.
Shouldn't "elinks-lite" is Suggests be "elinks | elinks-lite"? Or maybe
even "w3m | lynx | elinks | elinks-lite".
DEFAULT_PAGER is set to "less". It would be better to set it to "pager",
which is always available.
DEFAULT_EDITOR is set to "nano". It would be better to set it to
"sensible-editor".
ranger doesn't honour TMPDIR; also, as far as I can see, it creates
temporary files insecurely:
$ grep -r /tmp .
./ranger/__init__.py:LOGFILE = '/tmp/ranger_errorlog'
./ranger/core/actions.py: # self.previews['/tmp/foo.jpg'][(80, 24)] =
"the content..."
./ranger/core/actions.py: # self.previews['/tmp/foo.jpg']['loading']
= False
./ranger/core/main.py: cProfile.run('ranger.__fm.loop()',
'/tmp/ranger_profile')
./ranger/core/main.py: profile = pstats.Stats('/tmp/ranger_profile',
stream=sys.stderr)
./ranger.py:tempfile='/tmp/chosendir'
./examples/bash_automatic_cd.sh: tempfile='/tmp/chosendir'
./examples/vim_file_chooser.vim: exec "silent !ranger --choosefile=/tmp/chosenfile " .
expand("%:p:h")
./examples/vim_file_chooser.vim: if filereadable('/tmp/chosenfile')
./examples/vim_file_chooser.vim: exec 'edit ' . system('cat
/tmp/chosenfile')
./examples/vim_file_chooser.vim: call system('rm /tmp/chosenfile')
--
Jakub Wilk
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130323114507.ga4...@jwilk.net
