On Sat, Feb 08, 2014 at 08:20:38AM +0800, Paul Wise wrote: > > * Remove donation link in index.html (fix lintian E: > > privacy-breach-donation) in favor of debian/upstream > > This is *not* the right way to fix this issue. The form should remain, > just remove the problematic part of it (the images) and replace them > with text.
This is not clear from the http://lintian.debian.org/tags/privacy-breach-donation.html -->8-- Please remove this privacy problem and add a note to the debian/upstream file using the donation field. -->8-- Please, fix lintian text first. BTW, it's ok to include in the package downloaded images? > > * Removed Facebook's Share/Like buttons (fix lintian > > E:privacy-breach-facebook) > > Also the wrong approach, please replace them with text. Why? It's clearly stated in the lintian docs: http://lintian.debian.org/tags/privacy-breach-facebook.html -->8-- Please remove these scripts or frames. -->8-- Please, fix lintian text first. > In addition, while patching out the Facebook issue, you *should* have > noticed that there are two similar issues with Google+ and Twitter > right next to the Facebook JavaScript. Ok, I can remove this as well, when lintian could point to this. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20140208102540.ga12...@darkstar.order.hcn-strela.ru
