On Mon, Feb 10, 2014 at 3:50 PM, Jonathan Carter (highvoltage) <jonat...@ubuntu.com> wrote: > It builds the following binary package: > > speedtest-cli
I'd be happy to sponsor this package. Here's a quick review: 1) debian/watch needs to do some mangling of the version number to deal with the "v" Currently it reports: "Newest version on remote site is /v0.2.4, local version is 0.2.4" 2) debian/copyright has a minor issue. Even though a license is in common-licenses, you should still at least include the header. [0] Also, it strikes me as strange to use a more restrictive license for the files in debian/ than what upstream uses. 3) Is that debian/README.source really necessary? ;-) 4) debian/control should include a X-Python-Version field. From my build log: pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions pyversions: missing debian/pyversions file, fall back to supported versions [0] https://lists.debian.org/debian-devel-announce/2006/03/msg00023.html Thanks! -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cal6k_azfocr3ilvxawuhqpyfuwogfh2uvlywfhfg969ufvk...@mail.gmail.com
