On Wed, Apr 9, 2014 at 8:38 PM, Werner Mahr wrote: > I am looking for a sponsor for my package "isbg"
I don't intend to sponsor this but here is a review: Please include the manual page upstream and make setup.py install it properly. The url= line in setup.py is incorrectly indented with spaces instead of tabs. debian/copyright is missing the license information. debian/copyright contains a bogus URL to different software. You might want to use the machine-readable copyright format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ The empty Recommends/Suggests in debian/control are unnecessary. debian/changelog should only contain one entry not two: * Initial packaging (Closes: #587458) I would suggest using the new dh command from debhelper to reduce debian/rules to 3 lines, see the dh manual page for examples. http://manpages.debian.org/man0/dh https://penta.debconf.org/dc9_schedule/events/418.en.html Generally DH_VERBOSE is commented out in debian/rules. The package FTBFS when built twice in a row: dpkg-source: info: local changes detected, the modified files are: isbg-0.99/build/scripts-2.7/isbg.py isbg-0.99/isbg.egg-info/PKG-INFO isbg-0.99/isbg.egg-info/SOURCES.txt isbg-0.99/isbg.egg-info/dependency_links.txt isbg-0.99/isbg.egg-info/top_level.txt dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/isbg_0.99-1.diff.c121eq dpkg-source: info: you can integrate the local changes with dpkg-source --commit Automated checks: https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package lintian: I: isbg source: debian-watch-file-is-missing I: isbg: hyphen-used-as-minus-sign usr/share/man/man1/isbg.1.gz:46 dpkg-gencontrol: warning: package isbg: unused substitution variable ${python:Versions} duck: debian/control: Homepage: http://redmine.ookook.fr/projects/isbg: ERROR Curl:28 HTTP:0 Timeout was reached Connection timed out after 60001 milliseconds lintian4py: p: isbg source: insufficient-build-dependency-on-python-helper dh_python2 => python (>= 2.6.6-3~) x: isbg: except-without-exception-type usr/bin/isbg:207 x: isbg: except-without-exception-type usr/bin/isbg:214 x: isbg: except-without-exception-type usr/bin/isbg:356 x: isbg: except-without-exception-type usr/bin/isbg:370 x: isbg: except-without-exception-type usr/bin/isbg:383 x: isbg: except-without-exception-type usr/bin/isbg:434 x: isbg: except-without-exception-type usr/bin/isbg:461 x: isbg: except-without-exception-type usr/bin/isbg:501 x: isbg: except-without-exception-type usr/bin/isbg:527 x: isbg: except-without-exception-type usr/bin/isbg:552 x: isbg: except-without-exception-type usr/bin/isbg:601 p: isbg: SOURCES.txt-in-binary-package e: isbg: pyflakes-undefined-name usr/bin/isbg:377: imap pyflakes: ./isbg.py:377: undefined name 'imap' pep8: lots of warnings -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/caktje6fy30k8tom_gbqsjc_ratrrei7scu15g8mbpwxwgvf...@mail.gmail.com