* Daniel Echeverry <epsilo...@gmail.com>, 2014-05-10, 14:37:
http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc

Don't put two unrelated changes into a single patch. Could you split allow-cflags-override.diff into two, one for compiler flags, another one for installing icons?

It appears to me that files that are currently installed to /usr/share/sxiv/exec/ are just examples. If this is the case, then they should live in /usr/share/doc/sxiv/examples/.

icon/Makefile needs a “set -e”. Please see Policy §4.6.

Typo in sxiv.1: existance → existence.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140511194356.ga9...@jwilk.net

Reply via email to