>That's better. But let's remove “at line 75”. Removed.
>I found more misspellings: >exponentail -> exponential >swedish -> Swedish >outout -> output >supress -> suppress >varible -> variable >calcualated -> calculated >gernerate -> generate >explaination -> explanation >recommneds -> recommends >instad -> instead >japanese -> Japanese >Some of the above are also in debian/changelog.upstream. Fixed errors in changelog.upstream. Including crunch.1 file to patch fix_speeling. And fixed spelling errors. Fixed spelling errors in crunch.c. >I would write it in a similar way upstream did: >Copyright: 2004 mima...@aciiid.ath.cx I put now in copyright: Copyright: 2004 mima...@aciiid.ath.cx >If it's really that important for end users to know (I don't think it is, but >I'm not going to argue about it either), then more >obvious place this is >information is the changelog file itself. >Or alternatively, you could extract changelog from crunch.c comments, >therefore making it “official”. I extracted the changelog of crunc.c, now "official" rs. In a future I will use only the changelog to indicate that it is not official. >Minor nitpick about error handling in upstream code: > status = rename(fpath, outputfilename); /* rename from START to user > specified name */ > if (status != 0) { > fprintf(stderr,"Error renaming file. Status1 = %d Code = > %d\n",status,errno); > fprintf(stderr,"The problem is = %s\n", strerror(errno)); > exit(EXIT_FAILURE); > } >rename() always returns either 0 or -1, so there's little point in printing >the return code. >errno value could change between after the first call to printf(). If you want >to use the same errno in two library calls, you need to save it to a temporary >variable. >(There are more instances of similar code.) >This is nothing serious of course, but you may want to forward it upstream. Thanks, I'll forward to the upstream >The program can use lzma(1), bzip2(1), and 7z(1), so the package should >probaby have “xz-utils | lzma, bzip2, p7zip-full” in >Suggests. Added. Thanks for the help. Regards, -- Marcio Souza <m.desouz...@gmail.com>
pgpV8HOi2od9c.pgp
Description: PGP signature