On Thu, 10 Jul 2014, Jakub Wilk wrote:
That's an odd workflow, if you ask me. But oh well. Here's my quick review:
+ sed -n '/BEGIN PGP SIGNATURE/,/END PGP SIGNATURE/p' \
+ $(PNAME)_$${dvers}_source.changes >
$(PNAME)-$$vers.tar.gz.asc
I don't think you'll get a valid signature this way.
You are right - I have changed this to:
gpg --armor --detach-sig $(PNAME)-$$vers.tar.gz
+ - default postscript canava set to landscape with size-ratio of 0.71
Typo? canava -> canvas
+ - CONVFMT and OFMT varibles in 'awk' defined separately as "%.17g"
Typo: varibles -> variables
+Remark: an user-defined function should have syntax conform to 'awk'.
Typos: an -> a, conform -> conforming
Changes to packaging are not documented in debian/changelog.
--
Jakub Wilk
The typos are fixed and the changes to packaging are record in
debian/changelog. The new package with the same version number is uploaded
to m.d.n:
dget -x http://mentors.debian.net/debian/pool/main/s/stda/stda_1.3.1-1.dsc
Thanks for reviewing,
Dimitar
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
https://lists.debian.org/alpine.deb.2.00.1407101701390.16...@freeshell.de
