Hello Gergely,
first thnks for your review. Am Mittwoch, den 03.12.2014, 21:57 +0100 schrieb Gergely Nagy: > >>>>> "Jörg" == Jörg Frings-Fürst <deb...@jff-webhosting.net> writes: [...] > > As the former maintainer and upstream, there are a few issues I see with > the packaging (also sent earlier in private mail, but repeating here in > case someone was looking at the package and wanting to sponsor it). > > * Instead of disabling the watch file, if you tweak the regexp to only > match upstream releases, then it will work, and not catch my old > debian/ tags: > > ,---- > | version=3 > | > | https://github.com/algernon/libmongo-client/releases > .*/libmongo-client-([\d\.]+)\.tar\.gz > `---- Thanks. And changed to your version. > > * The build: target was there for a reason. Without it, we will build > the arch-indep stuff by default too, which is something we want to > avoid. > > For example, it will FTBFS on buildds, because they do not install > build-depends-indep. And we really don't want doxygen and graphviz in > B-D, because those pull in a shitload of stuff, to build docs that > will be discarded by buildds anyway. I fully agree with you. But where are the problem? The package has no FTBFS and I don't change your -arch / -indep division. Please can you specify your minds. > > * Why move --dbg-package from DH_OPTIONS to an override? > --dbg-package is only needed in dh_strip[1]. CU Jörg [1] https://wiki.debian.org/DebugPackage -- New: GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB 30EE 09F8 9F3C 8CA1 D25D GPG Key: 8CA1D25D CAcert Key S/N: 0E:D4:56 Old (will be revoked after 2014-12-31): pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E pgp Key: BE581B6E Jörg Frings-Fürst D-54526 Niederkail Threema: SYR8SJXB IRC: j_...@freenode.net j_...@oftc.net
signature.asc
Description: This is a digitally signed message part
