On 2 December 2015 at 13:33, Roger Shimizu <rogershim...@gmail.com> wrote: > Dear Felipe, > > Thanks for your favor! > >> - uscan tells me that there is no 1.29 version in the upstream page. >> And indeed there is only 1.28. What happened? >> - It would be great if you forward your patches upstream. > > I actually created the pkg repo by "gbp import-dscs --debsnap > adjtimex", so now I have all the history. > I found 1.29 version was introduced by "James R. Van Zandt > <j...@debian.org>", who acted both pkg maintainer and upstream > maintainer. > I guess he just released 1.29 and forgot to put it in upstream's website. > I didn't contact him and confirm this yet, but he seems to be MIA for > a few years. [0]
Hmm. It would be great if you could try reaching out anyway (there are a few more emails in the ChangeLog file). > >> - The dirs file is not needed. It is only useful when a package needs >> to ship a directory that is not created by anything else in the build >> process. In your case, all directories are created by either the >> upstream build system or the debhelper commands. >> - I would change all /bin/sh -e in maintainer scripts to use >> #!/bin/sh\nset -e. This way, if it is invoked via `sh $script`, then >> it will still get the -e option. > > Thanks for your advice! > I already modified as you suggest, and uploaded to mentors again. Looks good. There is only the slightly weird line about adding stuff to debian/dirs and then removing it ;) I will try to upload during the week, if I haven't by the weekend please ping me again. -- Saludos, Felipe Sateler