Hello,

On 2015-12-29 13:45 CET, Mattia Rizzolo <mat...@debian.org> wrote:

> As I said, the followings are not blocker, but unless you have a (good)
> reason for not doing them, I'd prefer to see them fixed/changed.
>
> * please use short format dh

done

> * add a Vcs-Browser field

done

> * please bump d/compat to 9

done

> * I'm pretty sure the *.dirs are mostly useless

removed

> * I know nothing of lips, and less about the packaging of lips stuff, but
>   isn't there a dh tool to autocreate the postinst snippet?

I tried dh_lisp but it doesn't seem to generate the postinst scripts. I
left the postinst script and will post on the pkg-common-lisp-devel ML
to find out more befor the next release.

> * from check-all-the-things:
>   + can you explain these?
>     - Warning in 'control binary:"cl-asdf" Recommends:1' value 'sbcl | 
> lisp-compiler': package lisp-compiler is unknown. Check for typos if not a 
> virtual package.

lisp-compiler is a virtual package: 
https://packages.debian.org/sid/lisp-compiler

>     - Warning in 'control binary:"cl-asdf" Breaks:0' value 'sbcl-common (<= 
> 1:0.9.13.0-2)': package sbcl-common is unknown. Check for typos if not a 
> virtual package.
>     - Warning in 'control binary:"cl-asdf" Replaces:0' value 'sbcl-common (<= 
> 1:0.9.13.0-2)': package sbcl-common is unknown. Check for typos if not a 
> virtual package. 

removed references to old package sbcl-common

>   + please fix the first and fix upstream the others:
>     - $ codespell --quiet-level=3
>       ./debian/changelog:1247: Seperate  ==> Separate

done

>       ./test/ecl-make-image/readme.lisp:62: doesnt  ==> doesn't
>       ./doc/asdf.texinfo:2992: throughly  ==> thoroughly

will submit a patch upstream


Thanks


Kambiz

Reply via email to