Package: x264 Version: 2:0.159.2999+git296494a-2 Severity: serious Tags: patch
Make 4.3 changed the escaping rules with the # symbol is used inside a parameter to functions like $shell. Previously it needed to be escaped, now it needs to *not* be escaped. A change was applied to the debian x264 package recently "debian/rules: Fix awk invocation" which presumablly fixed the build with make 4.3 but causes it to fail under 4.2 with the following error.
dpkg-buildpackage: info: host architecture amd64 debian/rules clean debian/rules:3: *** unterminated call to function 'shell': missing ')'. Stop. dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2
This has been seen on both reproducible builds and on the raspbian autoforwardporter. The upstream suggested solution to make a makefile that works with both 4.2 and 4.3 is to use a variable. I implemented that soloution and uploaded to Raspbian. The patch I used can be found at https://github.com/raspbian-packages/x264/commit/8b4de154127fdb95874d4d632431bbbabb3cbf64 If make 4.3 migrates to testing and this bug is not already fixed I will downgrade it. I still think this should be fixed even if/when bullseye gets 4.3 to make life easier for backporters. I do not have any immediate plans to NMU this, but this may change if the release gets closer and make 4.3 is still not in testing.
