Hi IOhannes,
On 2026-07-01 19:02, IOhannes m zmölnig wrote:
thanks a lot for the patches.
at first glance they look good to me (but little do I know of the
intricacies of PowerPC).
since you "#undef vector": couldn't we just re-define it to "__vector"
and be done with it?
Thanks for looking at this.
#define just replaces text everywhere, without understanding what it
means.
So it can't tell the difference between AltiVec's vector and
std::vector.
__vector is a real keyword the compiler understands directly, so this
problem doesn't happen.
That's why I changed each use to __vector instead of redefining the
macro.
Crypto++ also used same approach :
https://github.com/weidai11/cryptopp/blob/master/ppc_simd.h
gmdrsa
IOhannes
PS: as a sidenote: i generally find it a bit easier to review within
salsa as via email; but others might disagree so it's not a big issue.
Yes, understood!
I have opened below merge request debian salsa,
https://salsa.debian.org/multimedia-team/supercollider-sc3-plugins/-/merge_requests/4
Please review it, and let me know if you have any suggestions.
Thanks,
Trupti
