On Tue, Oct 31, 2000 at 10:10:13AM -0600, Steve Greenland wrote: > Generally very nice (haven't read the actual scripts yet...). I definitely > approve. > > I've one question/concern/objection, though. In your diff of 3.3.3.2, you > have: > > > > + By default, `invoke-rc.d' will pass any action requests (start, stop, > > + reload, restart...) to the /etc/init.d script, filtering out requests > > + to start a service out of its intended runlevels as defined by > > + `update-rc.d' and the system administrator. Also, requests to restart > > a > > + service out of its intended runlevels are changed to a stop request. > > The last sentence causes a problem in the following (contrived?) > scenario. > > 1. Daemon foo is not configured to run at current runlevel. > > 2. I, the sysadmin, have started foo by hand. > > 3. I do a apt-get upgrade, which includes a new versin of foo. Because > of "restart converted to stop", foo is stopped. > > I propose that instead of "restarts converted to stops" we just go with > "restarts ignored". I realize that this would cause the new version of > foo to be ignored, but that may be less surprising than having foo go > away completely,
I think the fundamental problem here is that we do not have a generic way of testing whether a service is running or not. If we did, then restart should mean "restart only if currently running", unless that is what "maybe-restart" is meant to mean.... Julian -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Julian Gilbey, Dept of Maths, QMW, Univ. of London. [EMAIL PROTECTED] Debian GNU/Linux Developer, see http://www.debian.org/~jdg Donate free food to the world's hungry: see http://www.thehungersite.com/