I've reviewed your patch.
It looks good.

One minor suggestion:

+The ``start``, ``stop``, ``restart``, and ``force-reload`` options should
+be supported by all init scripts. Supporting ``status`` is recommended but
+not required. The ``reload`` and ``try-restart`` options are optional.

How about supporting status is encouraged.
At this point in the game, do we really want people opening bugs because
an init script doesn't support status?

Besides that, LGTM.

Reply via email to